Subject: Re: repmgr.service
To: Justin King <jcking@mtu.edu>, pgsql-pkg-yum@postgresql.org
References: 
 <CAL3i3zT1NXVTyO=jOSXTnj3Uch9T569-LMyehDrUYqn0X+g2=w@mail.gmail.com>
From: =?UTF-8?Q?Mart=c3=adn_Marqu=c3=a9s?= <martin@2ndquadrant.com>
Message-ID: <56731A29.6080303@2ndquadrant.com>
Date: Thu, 17 Dec 2015 17:25:13 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: 
 <CAL3i3zT1NXVTyO=jOSXTnj3Uch9T569-LMyehDrUYqn0X+g2=w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

Hi,

I see this hasn't been committed yet into the pgrpms git repo.

Is it under review? If so I can say the changes are good, and if needed
I can send over a patch for easy applying.

Regards,


El 13/11/15 a las 22:59, Justin King escribió:
> Please modify the repmgr-9.x.service files for the packages.
> 
> The service files currently have:
> 
>     ExecStop=/usr/bin/kill -TERM ${PIDFILE}
>     ExecReload=/usr/bin/kill -HUP ${PIDFILE}
> 
> 
> /bin/kill does not accept files, you may be thinking of /bin/pkill -f 
> 
> Replace them with:
> 
>     ExecStop=/usr/bin/kill -TERM $MAINPID
>     ExecReload=/usr/bin/kill -HUP $MAINPID
> 
> 
> $MAINPID is a special systemd provided variable that references the
> known PID of the process 
> 
> And add the following under the [Service] section:
> 
>     PIDFile=/var/run/repmgr/repmgrd-9.x.pid
> 
> 
> This prevents systemd from guessing what the PID is and being wrong when
> Type=forking 
> 
> As it stands now `systemctl stop repmgrd` and `systemctl reload repmgrd`
> will always fail.
> 
> Justin


-- 
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum