public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ian Barwick <[email protected]>
To: [email protected]
Subject: Version number usage in new repmgr.spec file?
Date: Thu, 25 May 2017 13:30:07 +0900
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-pkg-yum>
Hi
I was looking at the new repmgr specfile (rpm/redhat/master/repmgr/master/repmgr.spec),
it looks like %{pgpackageversion} and %{pgmajorversion} have got a bit mixed up
in places; while it works for 10 of course, it looks like 9.6/96 etc. get written
to the wrong places.
Attached patch puts things the way they should be (at least to build a local
RPM with 9.x). Apologies for the noise if that's actually intentional.
Regards
Ian Barwick
--
Ian Barwick http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
Attachments:
[text/x-patch] repmgr.spec.diff (1.6K, 2-repmgr.spec.diff)
download | inline diff:
diff --git a/rpm/redhat/master/repmgr/master/repmgr.spec b/rpm/redhat/master/repmgr/master/repmgr.spec
index 028fcdd..c860a55 100644
--- a/rpm/redhat/master/repmgr/master/repmgr.spec
+++ b/rpm/redhat/master/repmgr/master/repmgr.spec
@@ -1,6 +1,6 @@
%global pgmajorversion 10
%global pgpackageversion 10
-%global pginstdir /usr/pgsql-%{pgpackageversion}
+%global pginstdir /usr/pgsql-%{pgmajorversion}
%global sname repmgr
%if 0%{?rhel} && 0%{?rhel} <= 6
%global systemd_enabled 0
@@ -10,7 +10,7 @@
%global _varrundir %{_localstatedir}/run/%{sname}
-Name: %{sname}%{pgmajorversion}
+Name: %{sname}%{pgpackageversion}
Version: 3.3.1
Release: 1%{?dist}
Summary: Replication Manager for PostgreSQL Clusters
@@ -41,10 +41,10 @@ Requires(postun): initscripts
Group: Applications/Databases
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%endif
-BuildRequires: postgresql%{pgmajorversion}, postgresql%{pgmajorversion}-devel
+BuildRequires: postgresql%{pgpackageversion}, postgresql%{pgpackageversion}-devel
BuildRequires: libxslt-devel, pam-devel, openssl-devel, readline-devel
BuildRequires: libmemcached-devel libicu-devel
-Requires: postgresql%{pgmajorversion}-server
+Requires: postgresql%{pgpackageversion}-server
%description
repmgr is an open-source tool suite to manage replication and failover in a
@@ -111,7 +111,7 @@ fi
%post
/sbin/ldconfig
%if %{systemd_enabled}
-%systemd_post %{sname}-%{pgmajorversion}.service
+%systemd_post %{sname}-%{pgpackageversion}.service
%tmpfiles_create
%else
# This adds the proper /etc/rc*.d links for the script
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Version number usage in new repmgr.spec file?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox