Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aBZXp-0000I0-CC for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 23 Dec 2015 02:52:53 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aBZXo-0000Xn-U3 for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 23 Dec 2015 02:52:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aBZXl-0000QI-GB for pgsql-pkg-yum@postgresql.org; Wed, 23 Dec 2015 02:52:49 +0000 Received: from smtp72.ord1c.emailsrvr.com ([108.166.43.72]) by magus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aBZXh-0004f5-R8 for pgsql-pkg-yum@postgresql.org; Wed, 23 Dec 2015 02:52:49 +0000 Received: from smtp18.relay.ord1c.emailsrvr.com (localhost.localdomain [127.0.0.1]) by smtp18.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 4E2292801B5; Tue, 22 Dec 2015 21:52:43 -0500 (EST) X-Auth-ID: jeff.frost@pgexperts.com Received: by smtp18.relay.ord1c.emailsrvr.com (Authenticated sender: jeff.frost-AT-pgexperts.com) with ESMTPSA id E794B2801AA; Tue, 22 Dec 2015 21:52:42 -0500 (EST) X-Sender-Id: jeff.frost@pgexperts.com Received: from [10.10.10.20] (8.202-62-69.ftth.swbr.surewest.net [69.62.202.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:25 (trex/5.5.4); Tue, 22 Dec 2015 21:52:43 -0500 Content-Type: multipart/alternative; boundary="Apple-Mail=_E8B06A34-63BF-412C-AE4F-5DB95D39F1D9" Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: repmgr.service From: Jeff Frost In-Reply-To: <56731A29.6080303@2ndquadrant.com> Date: Tue, 22 Dec 2015 18:52:42 -0800 Cc: Justin King , pgsql-pkg-yum@postgresql.org Message-Id: <8DCBFCBE-86BD-46D9-B089-B8FD049C0BA1@pgexperts.com> References: <56731A29.6080303@2ndquadrant.com> To: =?utf-8?Q?Mart=C3=ADn_Marqu=C3=A9s?= X-Mailer: Apple Mail (2.3112) X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --Apple-Mail=_E8B06A34-63BF-412C-AE4F-5DB95D39F1D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Sorry for the slow reply on this. We did make some changes recently, but it seems this was not one of = them. A patch would definitely speed us up and would be most welcome! > On Dec 17, 2015, at 12:25 PM, Mart=C3=ADn Marqu=C3=A9s = wrote: >=20 > Hi, >=20 > I see this hasn't been committed yet into the pgrpms git repo. >=20 > Is it under review? If so I can say the changes are good, and if = needed > I can send over a patch for easy applying. >=20 > Regards, >=20 >=20 > El 13/11/15 a las 22:59, Justin King escribi=C3=B3: >> Please modify the repmgr-9.x.service files for the packages. >>=20 >> The service files currently have: >>=20 >> ExecStop=3D/usr/bin/kill -TERM ${PIDFILE} >> ExecReload=3D/usr/bin/kill -HUP ${PIDFILE} >>=20 >>=20 >> /bin/kill does not accept files, you may be thinking of /bin/pkill -f=20= >>=20 >> Replace them with: >>=20 >> ExecStop=3D/usr/bin/kill -TERM $MAINPID >> ExecReload=3D/usr/bin/kill -HUP $MAINPID >>=20 >>=20 >> $MAINPID is a special systemd provided variable that references the >> known PID of the process=20 >>=20 >> And add the following under the [Service] section: >>=20 >> PIDFile=3D/var/run/repmgr/repmgrd-9.x.pid >>=20 >>=20 >> This prevents systemd from guessing what the PID is and being wrong = when >> Type=3Dforking=20 >>=20 >> As it stands now `systemctl stop repmgrd` and `systemctl reload = repmgrd` >> will always fail. >>=20 >> Justin >=20 >=20 > --=20 > Mart=C3=ADn Marqu=C3=A9s http://www.2ndQuadrant.com/ > PostgreSQL Development, 24x7 Support, Training & Services >=20 >=20 > --=20 > Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-pkg-yum --- Jeff Frost Director, PostgreSQL Experts, Inc. Phone: 1-888-PG-EXPRT x506 FAX: 415-762-5122 http://www.pgexperts.com/=20 --Apple-Mail=_E8B06A34-63BF-412C-AE4F-5DB95D39F1D9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Sorry for the slow reply on this.

We did make some changes = recently, but it seems this was not one of them.

A patch would definitely speed us up = and would be most welcome!


On = Dec 17, 2015, at 12:25 PM, Mart=C3=ADn Marqu=C3=A9s <martin@2ndquadrant.com> wrote:

Hi,
I see this hasn't been committed yet into the = pgrpms git repo.

Is it under review? If so = I can say the changes are good, and if needed
I can send = over a patch for easy applying.

Regards,


El 13/11/15 a las 22:59, Justin = King escribi=C3=B3:
Please modify the repmgr-9.x.service files for the = packages.

The service files currently = have:

=    ExecStop=3D/usr/bin/kill -TERM ${PIDFILE}
=    ExecReload=3D/usr/bin/kill -HUP ${PIDFILE}


/bin/kill does not accept = files, you may be thinking of /bin/pkill -f

Replace them with:

=    ExecStop=3D/usr/bin/kill -TERM $MAINPID
=    ExecReload=3D/usr/bin/kill -HUP $MAINPID


$MAINPID is a special systemd = provided variable that references the
known PID of the = process

And add the following under the = [Service] section:

=    PIDFile=3D/var/run/repmgr/repmgrd-9.x.pid


This prevents systemd from = guessing what the PID is and being wrong when
Type=3Dforking=

As it stands now `systemctl stop repmgrd` = and `systemctl reload repmgrd`
will always fail.

Justin


--
Mart=C3=ADn Marqu=C3=A9s =             &n= bsp;  http://www.2ndQuadrant.com/
PostgreSQL = Development, 24x7 Support, Training & Services


--
Sent via pgsql-pkg-yum = mailing list (pgsql-pkg-yum@postgresql.org)
To make = changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum

---
Jeff Frost <jeff@pgexperts.com>
Director, = PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT = x506
FAX: 415-762-5122
http://www.pgexperts.com/ 




= --Apple-Mail=_E8B06A34-63BF-412C-AE4F-5DB95D39F1D9--