Message-ID: <972cffe806a4dad5e3d3149565e9b01ef40da55c.camel@gunduz.org>
Subject: Re: 9.4.19 devel packages pg_config.h broken
From: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org>
To: Craig Ringer <craig@2ndquadrant.com>, pgsql-pkg-yum
	 <pgsql-pkg-yum@postgresql.org>
Date: Thu, 16 Aug 2018 08:58:48 +0100
In-Reply-To: 
 <CAMsr+YGkkbB2VQsw4-kE36SO9hsgywCSCdb6Z0GafSjY5dDR+g@mail.gmail.com>
References: 
	<CAMsr+YGkkbB2VQsw4-kE36SO9hsgywCSCdb6Z0GafSjY5dDR+g@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-4vQQzk8ebL1A38rMm2nK"
Mime-Version: 1.0
Precedence: bulk


--=-4vQQzk8ebL1A38rMm2nK
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Hi Craig,

Petr also pinged me privately about this, and John fixed it yesterday. The =
new
packages are up. Thanks for the report!

I broke it while unifying the spec file, as you guessed.

Regards, Devrim

On Wed, 2018-08-15 at 16:58 +0800, Craig Ringer wrote:
> Hi folks
>=20
> The 9.4.19 devel package appears to have a misplaced pg_config.h. Compare=
:
>=20
> $ rpm -qlp ~/Downloads/postgresql94-devel-9.4.19-1PGDG.f27.x86_64.rpm |gr=
ep
> 'pg_config.h'
> /usr/pgsql-9.4/include/postgresql-94-ecpg_config.h
> /usr/pgsql-9.4/include/postgresql-94-pg_config.h
> /usr/pgsql-9.4/include/server/postgresql-94-pg_config.h
>=20
> with
>=20
> $ rpm -qlp ~/Downloads/postgresql96-devel-9.6.10-1PGDG.f27.x86_64.rpm |gr=
ep
> 'pg_config.h'
> /usr/pgsql-9.6/include/ecpg_config.h
> /usr/pgsql-9.6/include/pg_config.h
> /usr/pgsql-9.6/include/server/pg_config.h
>=20
> Note we have postgresql-94-pg_config.h in 9.4, and pg_config.h in 9.6.
>=20
> I suspect this was an unintended change. I can't see where it came from i=
n
> any recent commits, which is a bit surprising.
>=20
> There's
>=20
> Source5:    %{sname}-%{pgmajorversion}-pg_config.h
>=20
> in the redhat master packages for postgresql, but that's fine/normal.
> Changes in 3a4b12670 on May 10 added unified Makefile for PostgreSQL 9.4,
> which seems to have changed
>=20
> Source5:    pg_config.h
> to
> Source5:    %{sname}-%{pgmajorversion}-pg_config.h
>=20
> and I'm guessing the problem got introduced there somehow.
>=20
> I suspect the issue is that the 9.4
> spec rpm/redhat/9.4/postgresql/master/postgresql-9.4.spec has
>=20
>                 %{__install} -m 644 %{SOURCE5}
> %{buildroot}%{pgbaseinstdir}/include/
>=20
> (line 715)
>=20
> wheras the pg10 spec rpm/redhat/10/postgresql/master/postgresql-10.spec h=
as
>=20
>                 %{__install} -m 644 %{SOURCE5}
> %{buildroot}%{pgbaseinstdir}/include/pg_config.h
>=20
> Note the destination file name specified for pg10 but not 9.4.
>=20
>=20
>=20
>=20

--=20
Devrim G=C3=BCnd=C3=BCz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

--=-4vQQzk8ebL1A38rMm2nK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIyBAABCAAdFiEEH8GKHNUOKtDEiyD22MM9/pLPbrUFAlt1LrgACgkQ2MM9/pLP
brUHyg/2O7vaGfkY4tVNE+xIl0cxmZputI5HMJyPWoox3FPYdJB+Se9DPRxh6DO9
aB3EioSyTxoRz0MDe8XJTl6fX9V8UrmJ+iEnhQIZaqkbqNjXNMSRjvgD5nZuDi2N
ZzBFgxEGQlw1GrrdxW3WWHwJQcYla9SHeLuQAk13c1Z9gdq56u6WP+PNdo+8cBI4
gtFeJlMPZ7EZ23wPP9QQBHEJ36OtSN+QzkpBgFjV1lXogiKlHel9G3wKxbjVXXf+
rsgOoaoXI2Gn6c4qlKldSngxP1d6krsyBve8rrF8eXYVphos1uQ2z3CJcMYHBsxl
x26qflgg++9dXxQc4fzofR7bvn40OzYeANJqvOc6kLt5g3XLM9ozFYlwYg8bcGON
aWr7dgVnDo0jZ5qhCfgR+wnlxK2hAs49vdyaJRw0AsEZUQDH/TPWr/E+tYEahvyL
es2J3W7Cvpjn0/FNA1c6WEeCwLEtU6cXLcv3O9s2WQFNCw94L5HCjOSJ2zk9eFct
D9qqWOv26VmiHrxUvJdlU3BbVBAgBA8YKFsIWm3ISxxtLMKUm2FimdbaPzLY+9xs
HGlKKZut9B1MPcauu3iunPtEDCSHQPzbUuvvXgsEkzEcTZlHK34vsNxqdFBjeabL
wUAPag9nQnIgGmSZ5/hSOXOS9p9vIYKNOnoodahtT82ABjeiFw==
=gaay
-----END PGP SIGNATURE-----

--=-4vQQzk8ebL1A38rMm2nK--