MIME-Version: 1.0
References: <29a4702cc1d06152c970c8bbbbfa109f36100ee0.camel@gunduz.org>
 <CAGRY4nz=8bD_NEhFqXP3FE1zsfpSTNn83jSLRLgkuJHPpRZNcw@mail.gmail.com>
In-Reply-To: 
 <CAGRY4nz=8bD_NEhFqXP3FE1zsfpSTNn83jSLRLgkuJHPpRZNcw@mail.gmail.com>
From: Heath Lord <heath.lord@crunchydata.com>
Date: Fri, 2 Oct 2020 07:04:16 -0400
Message-ID: 
 <CA+BEBhukkX5ez12RWa6b9vUHTAd7dGsz2pwt+5TWcPP-3LTGpg@mail.gmail.com>
Subject: Re: A basic spec file question
To: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>,
	PostgreSQL YUM ML <pgsql-pkg-yum@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Devrim,

   The issue is with the "<=3D" in this line:

%if 0%{?fedora} <=3D 31 || 0%{?rhel} <=3D 8 || 0%{?suse_version} >=3D 1315

   With the "0%{variable}" format you will get "0" whenever a variable
is not defined, so whenever you do a comparison with a "<=3D" it will
resolve to TRUE when that variable is undefined.  Since fedora and
rhel are never both defined at the same time the above logic will
always resolve to being TRUE.
   Anytime you use this comparison logic to determine whether the
variable is "<=3D"  you will also have to verify that the variable is
defined as well.

Thanks,
   Heath

On Fri, Oct 2, 2020 at 5:38 AM Craig Ringer
<craig.ringer@enterprisedb.com> wrote:
>
> Add a %dump at the end of the spec file body and/or relevant parts throug=
hout to see how it evaluated. %echo macros are useful too
>
> On Fri, 2 Oct 2020, 17:08 Devrim G=C3=BCnd=C3=BCz, <devrim@gunduz.org> wr=
ote:
>>
>>
>>
>> Hi,
>>
>> I am probably missing a very basic thing, but... What is wrong in this
>> line? I am expecting Fedora 32 and 33 not do depend on CGAL package,
>> but then the Fedora 33 RPM depends on CGAL >=3D 4.7 .
>>
>> https://git.postgresql.org/gitweb/?p=3Dpgrpms.git;a=3Dblob;f=3Drpm/redha=
t/master/common/sfcgal/master/sfcgal.spec;h=3D2678073373595d042341fe9724db6=
ccf1f2daacf;hb=3Db57f568a1eb1780a397d4c25c46c678399048e9b#l26
>>
>> What am I missing?
>>
>> Regards,
>> --
>> Devrim G=C3=BCnd=C3=BCz
>> Open Source Solution Architect, Red Hat Certified Engineer
>> Twitter: @DevrimGunduz , @DevrimGunduzTR