Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3r87-00041U-TW for pgsql-pkg-yum@arkaria.postgresql.org; Thu, 27 Apr 2017 21:39:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3r87-0002PY-GL for pgsql-pkg-yum@arkaria.postgresql.org; Thu, 27 Apr 2017 21:39:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3r83-0002Is-8w for pgsql-pkg-yum@postgresql.org; Thu, 27 Apr 2017 21:39:11 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3r7z-0000o5-Bi for pgsql-pkg-yum@postgresql.org; Thu, 27 Apr 2017 21:39:10 +0000 Received: by mail-io0-x22e.google.com with SMTP id k87so37266665ioi.0 for ; Thu, 27 Apr 2017 14:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crunchydata-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=No63pNGQscLGPghW5lJIfN/QxpWbcjWylBdDpu6U8I4=; b=1q6PgEM0gQoTylYFYUjHqtLAKtoh27kErZelpfk64p2uaA0YxtfjmlYNKEM+rPk6/H IGVyz4k9aeLFs3tK9NOe4cnzBwaCkCZMjf+DScHNDGCrwgCoFVQvIVHxJtXyO2zV/2Ae mqxTC5Pj5ruUXE/KP3ODwprv9uHOfn2E5pB+qUg/JTT1lSN1/nb15rzqgw9gRPjEqBno rJ8NHQ5jOQewU8+Gh3KMEcFrsT4qoWozwfBS2mDBqz+UDniGFJY9B6q3meNJYQgNUj1T VfjTOsSQpbI2Z3cuFXwf48sB7lZToSMZlABST8LThC7Q4k8vjeMfpAgDqNi+VoWCZvaE OoSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=No63pNGQscLGPghW5lJIfN/QxpWbcjWylBdDpu6U8I4=; b=Z4lvp3Q7TlPKEKyJdfCVBO098K0hSx5wZGKq+IidXCQpG+NRBNNzJ5+nK77ZtxfNAn /Lia40FoYvYob8mrN/9kqIs+ZCu+xf21Or9B2bZKpeY7Fs/H+8EpP2Zrf82522QhR9/P WA8K4o38oijQRcVuk67nhSwe0BG3Sutsd7pBv/xp3bzwhljG5HS3ZOE7SMpGEjhZjmFW RPFU5hLevzr3r6SNeGXy2Qe8v8LwysO1TcQ4q1DljJrA8D7t+RtgMIEJ50QQIV4f0tgp IbE2DOjvaTVorhLooS3if74mjoMNdbzY1S2Lh7tJflu3pZUx9x1GPKXy6PTE8c+UmiIb KvOw== X-Gm-Message-State: AN3rC/45RwZKIcOkAD6bBbCjOQbrJNx1j9CNy6wRGttw+ibmVmxb+Nfb 72dApVqxqCv8hdRIuxsK3hHth1gNJqMc X-Received: by 10.157.61.52 with SMTP id a49mr3881372otc.30.1493329145179; Thu, 27 Apr 2017 14:39:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.115.69 with HTTP; Thu, 27 Apr 2017 14:38:24 -0700 (PDT) In-Reply-To: <1493289313.3032.46.camel@gunduz.org> References: <1493289313.3032.46.camel@gunduz.org> From: John Harvey Date: Thu, 27 Apr 2017 17:38:24 -0400 Message-ID: Subject: Re: pgadmin4 RPM broken? To: pgsql-pkg-yum Content-Type: multipart/alternative; boundary=001a114093223b4465054e2cc9ec X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --001a114093223b4465054e2cc9ec Content-Type: text/plain; charset=UTF-8 Hi Devrim, Wow, I was sure that I tested this, but apparently I did not. I see your > point. > Actually the recent spec file in the repo should be good (as a part of > some new > repo announcement), so I need to rebuild pgadmin4 RPM using that spec file. > > Will do. No worries. I know that things have been busy. BTW, I did some test building with the latest spec on RHEL7, since you mentioned you're thinking of a rebuild/re-release. I had a few findings that may be of use, if you are still finalizing the spec-file. Some of these are small and have to do with a few of the new pgadmin4-python packages. 1) I noticed that there is no pgadmin4-babel directory in the 9.5 folder, but it exists in 9.6. Does it make sense to copy that over to 9.5 (and pg10) as well? It is a necessary build dependency for pgadmin4-python-flask-babel. 2) Do you think it makes sense to change the name of the pgadmin4-babel specfile (babel.spec) to pgadmin4-babel.spec to match the other pgadmin4 specfile naming conventions? 3) In the yum repository, one of the pgadmin4-python RPM's has some strange capitalization in the RPM name: pgadmin4-python-Flask-Mail-0.9.1-3.rhel6.noarch.rpm. Should this all be lowercase? 4) When I try building with the current pgadmin4 specfile on RHEL7, I get an error at patch-time: + cd pgadmin4-1.3 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + echo 'Patch #0 (pgadmin4-sphinx-theme.patch):' Patch #0 (pgadmin4-sphinx-theme.patch): + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-sphinx-theme.patch + /usr/bin/patch -p0 --fuzz=0 patching file docs/en_US/conf.py + echo 'Patch #4 (pgadmin4-rhel7-sphinx.patch):' Patch #4 (pgadmin4-rhel7-sphinx.patch): + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-rhel7-sphinx.patch + /usr/bin/patch -p0 --fuzz=0 patching file docs/en_US/Makefile.sphinx Reversed (or previously applied) patch detected! Assume -R? [n] I'm not sure why this occurs. I'll keep investigating. 5) I suggest that the pgadmin4 specfile should add the following line: BuildRequires: pgadmin4-python-flask-mail Without it (assuming I remove the patch line from my issue 4 above), I see this when I compile pgadmin4: Running Sphinx v1.1.3 Exception occurred: File "/usr/lib/python2.7/site-packages/pgadmin4-web/flask_security/utils.py", line 27, in from flask_mail import Message ImportError: No module named flask_mail After that, the build fails. Note that this is solved when I install the pgadmin4-python-flask-mail RPM directly. 6) I suggest that the pgadmin4 specfile should add the following line: BuildRequires: pgadmin4-python-dateutil Without it (assuming I remove the patch line from my issue 4 above), I see this when I compile pgadmin4: Making output directory... Running Sphinx v1.1.3 Exception occurred: File "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/utils/preferences.py", line 17, in import dateutil.parser as dateutil_parser ImportError: No module named dateutil.parser After that, the build fails. Note that this is solved when I install the pgadmin4-python-dateutil RPM. 7) I think the pgadmin4 specfile may need the following line: BuildRequires: pgadmin4-python-flask-gravatar Without it (assuming I remove the patch line from my issue 4 above), I see this when I compile pgadmin4: + make PYTHON=/usr/bin/python docs LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 make -C docs/en_US -f Makefile.sphinx html make[1]: Entering directory `pgadmin4/BUILD/pgadmin4-1.3/docs/en_US' Generating code-snippet.rst for some of the important classes... Traceback (most recent call last): File "build_code_snippet.py", line 61, in from pgadmin.browser.utils import NodeView File "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/browser/__init__.py", line 18, in from flask_gravatar import Gravatar ImportError: No module named flask_gravatar make[1]: [code_snippet] Error 1 (ignored) Granted, this is an error that is ignored (the build continues), but I think people may encounter unexpected behavior without it. I hope these are helpful. Regards, -John --001a114093223b4465054e2cc9ec Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Devrim,

Wow, I was = sure that I tested this, but apparently I did not. I see your point.
Actually the recent spec file in the repo should be good (as a part of some= new
repo announcement), so I need to rebuild pgadmin4 RPM using that spec file.=

Will do.

No worries.=C2=A0 I know that thin= gs have been busy.

BTW, I did some test building w= ith the latest spec on RHEL7, since you mentioned you're thinking of a = rebuild/re-release.
I had a few findings that may be of use, = if you are still finalizing the spec-file.
Some of these are = small and have to do with a few of the new pgadmin4-python packages.
<= div>
1) I noticed that there is no pgadmin4-babel directory i= n the 9.5 folder, but it exists in 9.6.=C2=A0 Does it make sense to copy th= at over to 9.5 (and pg10) as well?=C2=A0 It is a necessary build dependency= for=C2=A0pgadmin4-python-flask-babel.

2) Do you think it= makes sense to change the name of the pgadmin4-babel specfile (babel.spec)= to pgadmin4-babel.spec to match the other pgadmin4 specfile naming convent= ions?

3) In the yum repository, one of the pgadmin= 4-python RPM's has some strange capitalization in the RPM name: pgadmin= 4-python-Flask-Mail-0.9.1-3.rhel6.noarch.rpm.=C2=A0 Should this all be= lowercase?

4) When I try building with the current pgadm= in4 specfile on RHEL7, I get an error at patch-time:

+ cd pg= admin4-1.3
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ echo &= #39;Patch #0 (pgadmin4-sphinx-theme.patch):'
Patch #0 = (pgadmin4-sphinx-theme.patch):
+ /usr/bin/cat pgadmin4/SOURCES/= pgadmin4-sphinx-theme.patch
+ /usr/bin/patch -p0 --fuzz=3D= 0
patching file docs/en_US/conf.py
+ echo 'Patc= h #4 (pgadmin4-rhel7-sphinx.patch):'
Patch #4 (pgadmin= 4-rhel7-sphinx.patch):
+ /usr/bin/cat pgadmin4/SOURCES/pgadmin4= -rhel7-sphinx.patch
=
+ /usr/bin/patch -p0 --fuzz=3D0
<= /div>
patching file docs/en_US/Makefile.sphinx
Reversed (or pre= viously applied) patch detected!=C2=A0 Assume -R? [n]

I'm not sure why this occurs.=C2=A0 I'= ;ll keep investigating.

5) I suggest that the pgadmin4 s= pecfile should add the following line: BuildRequires: pgadmin4-python-flask= -mail
Without it (assuming I remove the patch line from my issue = 4 above), I see this when I compile pgadmin4:

Running Sphinx v1.1.3

Exception occurred:
=
=C2=A0 File "/usr/lib/python2.7/site-packages/pgadmin4-= web/flask_security/utils.py", line 27, in <module>
=C2=A0 =C2=A0 from flask_mail import Message
ImportError: No module named flask_mail
<= div>
After that, the build fails.
Note that this is= solved when I install the pgadmin4-python-flask-mail RPM directly.

6) I suggest that the pgadmin4 specfile should add the fo= llowing line: BuildRequires: pgadmin4-python-dateutil
Without it = (assuming I remove the patch line from my issue 4 above), I see this when I= compile pgadmin4:

Making output directory...
Running Sphinx v1.1.3

Exception occurred:
<= div class=3D"gmail_extra">
=C2=A0 File = "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/utils/preferences.p= y", line 17, in <module>
=C2=A0 =C2=A0 im= port dateutil.parser as dateutil_parser
<= div class=3D"gmail_extra">
ImportError:= No module named dateutil.parser
=

<= div>
After that, the build fails.
Note that this i= s solved when I install the pgadmin4-python-dateutil=C2=A0RPM.
<= div>
7) I think the pgadmin4 specfile may need the following = line: BuildRequires: pgadmin4-python-flask-gravatar
Without = it (assuming I remove the patch line from my issue 4 above), I see this whe= n I compile pgadmin4:

+ make PYTHON=3D/usr= /bin/python docs
LC_ALL=3Den_US.UTF-8 LANG=3Den_US.UTF-8 = make -C docs/en_US -f Makefile.sphinx html
make[1]: Entering di= rectory `pgadmin4/BUILD/pgadmin4-1.3/docs/en_US'
=
Gener= ating code-snippet.rst for some of the important classes...
Tra= ceback (most recent call last):
=C2=A0 File "build_code_sn= ippet.py", line 61, in <module>
=C2=A0 =C2=A0 from p= gadmin.browser.utils import NodeView
=C2=A0 File "pgadmin4= /BUILD/pgadmin4-1.3/web/pgadmin/browser/__init__.py", line 1= 8, in <module>
=C2=A0 =C2=A0 from flask_gravatar import G= ravatar
ImportError: No module named flask_gravatar
make[1]: [code_snippet] Error 1 (ignored)

Granted, this is an error that is ignored (the build c= ontinues), but I think people may encounter unexpected behavior without it.=


I hope these are helpful.

=
Regards,
=C2=A0 -John
--001a114093223b4465054e2cc9ec--