MIME-Version: 1.0
In-Reply-To: <1493541308.14590.2.camel@gunduz.org>
References: 
 <CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
 <1493289313.3032.46.camel@gunduz.org>
 <CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
 <1493386507.11169.12.camel@gunduz.org>
 <CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
 <1493541308.14590.2.camel@gunduz.org>
From: John Harvey <john.harvey@crunchydata.com>
Date: Mon, 1 May 2017 08:15:03 -0400
Message-ID: 
 <CABcP5fiHShZEJg6QSXcKkL=_tQt0_bSDWiH8V7VXgJSvMRuupA@mail.gmail.com>
Subject: Re: pgadmin4 RPM broken?
To: pgsql-pkg-yum <pgsql-pkg-yum@postgresql.org>
Content-Type: multipart/alternative; boundary=001a113dd214e544ae054e75619f
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

--001a113dd214e544ae054e75619f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Devrim,

On Sun, Apr 30, 2017 at 4:35 AM, Devrim G=C3=BCnd=C3=BCz <devrim@gunduz.org=
> wrote:

>
> > I think that these lines should actually now be moved to:
> > Requires:       pgadmin4-python-itsdangerous >=3D 0.24
> >
> > Is that a correct assumption?
>
> I changed Python2 part only, and that was a great catch. Thanks!
>

It looks pretty good so far.  I think there's one last change needed based
on your most recent commit.
The line below appears to now be broken:

BuildRequires: python-itsdangerous >=3D 0.24 pgadmin4-python-flask-htmlmin

I think it should be:

BuildRequires: pgadmin4-python-itsdangerous >=3D 0.24
pgadmin4-python-flask-htmlmin

Without this change, I am unable to build on EL-7 since the base
python-itsdangerous package only goes up to 0.23.
However, if I make the above change, I can build successfully on EL-7.

The new spec file is in the repo now. Thanks for looking at this, it was
> great!


No problem.  Glad to help! :)

Regards,
  -John

--001a113dd214e544ae054e75619f
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Devrim,<div><br></div><div class=3D"gmail_extra"><div c=
lass=3D"gmail_quote">On Sun, Apr 30, 2017 at 4:35 AM, Devrim G=C3=BCnd=C3=
=BCz <span dir=3D"ltr">&lt;<a href=3D"mailto:devrim@gunduz.org" target=3D"_=
blank">devrim@gunduz.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,20=
4,204);padding-left:1ex"><span class=3D"gmail-"><br>&gt; I think that these=
 lines should actually now be moved to:<br>
&gt; Requires:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pgadmin4-<wbr>pytho=
n-itsdangerous &gt;=3D 0.24<br>
&gt;<br>
&gt; Is that a correct assumption?<br>
<br>
</span>I changed Python2 part only, and that was a great catch. Thanks!<br>=
</blockquote><div><br></div><div>It looks pretty good so far.=C2=A0 I think=
 there&#39;s one last change needed based on your most recent commit.</div>=
<div>The line below appears to now be broken:<br></div><div><div><br></div>=
<div>BuildRequires: python-itsdangerous &gt;=3D 0.24 pgadmin4-python-flask-=
htmlmin</div><div><br></div><div>I think it should be:<br></div></div><div>=
<br></div><div>BuildRequires: pgadmin4-python-itsdangerous &gt;=3D 0.24 pga=
dmin4-python-flask-htmlmin</div><div><br></div><div>Without this change, I =
am unable to build on EL-7 since the base python-itsdangerous package only =
goes up to 0.23.</div><div>However, if I make the above change, I can build=
 successfully on EL-7.</div><div><br></div><blockquote class=3D"gmail_quote=
" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);=
padding-left:1ex">
The new spec file is in the repo now. Thanks for looking at this, it was gr=
eat!</blockquote><div><br></div><div>No problem.=C2=A0 Glad to help! :)=C2=
=A0</div><div><br></div><div>Regards,</div><div>=C2=A0 -John</div></div></d=
iv></div>

--001a113dd214e544ae054e75619f--