MIME-Version: 1.0
In-Reply-To: <1493386507.11169.12.camel@gunduz.org>
References: 
 <CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
 <1493289313.3032.46.camel@gunduz.org>
 <CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
 <1493386507.11169.12.camel@gunduz.org>
From: John Harvey <john.harvey@crunchydata.com>
Date: Fri, 28 Apr 2017 16:05:11 -0400
Message-ID: 
 <CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
Subject: Re: pgadmin4 RPM broken?
To: pgsql-pkg-yum <pgsql-pkg-yum@postgresql.org>
Content-Type: multipart/alternative; boundary=001a113ddb94b7570d054e3f99d4
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

--001a113ddb94b7570d054e3f99d4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Devrim,

Thanks for putting all of the changes in.  They all work great!

On Fri, Apr 28, 2017 at 9:35 AM, Devrim G=C3=BCnd=C3=BCz <devrim@gunduz.org=
> wrote:

>
> > 4) When I try building with the current pgadmin4 specfile on RHEL7, I g=
et
> > an error at patch-time:
> > Reversed (or previously applied) patch detected!  Assume -R? [n]
> >
> > I'm not sure why this occurs.  I'll keep investigating.
>
> Can't reproduce -- can you please clean up your repo and try again?


I keep seeing it even in a clean repo, but I'll try to dig a little deeper.
It could definitely be something in my environment.
I'll try to provide more helpful information if it is something that's a
problem.


I found two more specfile recommendations today after some more testing:

1) I would suggest adding "BuildRequires: pgadmin4-python-simplejson" to
the pgadmin4 specfile.

Without it, I see this trace in the build log:

Generating code-snippet.rst for some of the important classes...
Traceback (most recent call last):
  File "build_code_snippet.py", line 61, in <module>
    from pgadmin.browser.utils import NodeView
  File "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/browser/__init__.py", line
19, in <module>
    from pgadmin.settings import get_setting
  File "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/settings/__init__.py", line
19, in <module>
    from pgadmin.utils.ajax import make_json_response, bad_request
  File "pgadmin4/BUILD/pgadmin4-1.3/web/pgadmin/utils/ajax.py", line 15, in
<module>
    import simplejson as json
ImportError: No module named simplejson
make[1]: [code_snippet] Error 1 (ignored)
sphinx-build -b html -d _build/doctrees   . _build/html

The build continues even with the failure, but my guess is that it's not
ideal.


2) I think that two Requires lines may need to change, specifically around
python-itsdangerous

Requires:       python3-itsdangerous >=3D 0.24
Requires:       python-itsdangerous >=3D 0.24

On CentOS 7, python-itsdangerous-0.23-2.el7.noarch is available from the
@extras packages
On RHEL 7, python-itsdangerous-0.23-2.el7.noarch is available from the
@rhel-7-server-extras-rpms packages
Unfortunately, these are too low of a version.  I'm guessing we want to use
the PGDG-built version.

I think that these lines should actually now be moved to:
Requires:       pgadmin4-python-itsdangerous >=3D 0.24

Is that a correct assumption?


After making those two modifications (and ignoring the patchfile, which I'm
investigating), I am able to build and install pgadmin4 successfully with
the new specfile, which is pretty awesome.

Thanks!
  -John

--001a113ddb94b7570d054e3f99d4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Devrim,<div class=3D"gmail_extra"><br></div><div class=
=3D"gmail_extra">Thanks for putting all of the changes in.=C2=A0 They all w=
ork great!</div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">O=
n Fri, Apr 28, 2017 at 9:35 AM, Devrim G=C3=BCnd=C3=BCz <span dir=3D"ltr">&=
lt;<a href=3D"mailto:devrim@gunduz.org" target=3D"_blank">devrim@gunduz.org=
</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
><span class=3D"m_-1875773353214313183gmail-m_4394653700829738747gmail-"><b=
r></span><span class=3D"m_-1875773353214313183gmail-m_4394653700829738747gm=
ail-">&gt; 4) When I try building with the current pgadmin4 specfile on RHE=
L7, I get<br>
&gt; an error at patch-time:<br>&gt; Reversed (or previously applied) patch=
 detected!=C2=A0 Assume -R? [n]<br>
&gt;<br>
&gt; I&#39;m not sure why this occurs.=C2=A0 I&#39;ll keep investigating.<b=
r>
<br>
</span>Can&#39;t reproduce -- can you please clean up your repo and try aga=
in?</blockquote><div><br></div><div>I keep seeing it even in a clean repo, =
but I&#39;ll try to dig a little deeper.</div><div>It could definitely be s=
omething in my environment.</div><div>I&#39;ll try to provide more helpful =
information if it is something that&#39;s a problem.</div><div><br></div><d=
iv><br></div><div>I found two more specfile recommendations today after som=
e more testing:</div><div><br></div><div>1) I would suggest adding &quot;Bu=
ildRequires: pgadmin4-python-simplejson&quot; to the pgadmin4 specfile.</di=
v><div><br></div><div>Without it, I see this trace in the build log:</div><=
div><br></div><div><div>Generating code-snippet.rst for some of the importa=
nt classes...</div><div>Traceback (most recent call last):</div><div>=C2=A0=
 File &quot;build_code_snippet.py&quot;, line 61, in &lt;module&gt;</div><d=
iv>=C2=A0 =C2=A0 from pgadmin.browser.utils import NodeView</div><div>=C2=
=A0 File &quot;pgadmin4/BUILD<wbr>/pgadmin4-1.3/web/pgadmin/<wbr>browser/__=
init__.py&quot;, line 19, in &lt;module&gt;</div><div>=C2=A0 =C2=A0 from pg=
admin.settings import get_setting</div><div>=C2=A0 File &quot;pgadmin4/BUIL=
D<wbr>/pgadmin4-1.3/web/pgadmin/<wbr>settings/__init__.py&quot;, line 19, i=
n &lt;module&gt;</div><div>=C2=A0 =C2=A0 from pgadmin.utils.ajax import mak=
e_json_response, bad_request</div><div>=C2=A0 File &quot;pgadmin4/BUILD<wbr=
>/pgadmin4-1.3/web/pgadmin/<wbr>utils/ajax.py&quot;, line 15, in &lt;module=
&gt;</div><div>=C2=A0 =C2=A0 import simplejson as json</div><div>ImportErro=
r: No module named simplejson</div><div>make[1]: [code_snippet] Error 1 (ig=
nored)</div><div>sphinx-build -b html -d _build/doctrees =C2=A0 . _build/ht=
ml</div></div><div><br></div><div>The build continues even with the failure=
, but my guess is that it&#39;s not ideal.</div><div><br></div><div><br></d=
iv><div>2) I think that two Requires lines may need to change, specifically=
 around python-itsdangerous</div><div><br></div><div>Requires: =C2=A0 =C2=
=A0 =C2=A0 python3-itsdangerous &gt;=3D 0.24<br></div><div>Requires: =C2=A0=
 =C2=A0 =C2=A0 python-itsdangerous &gt;=3D 0.24<br></div><div><br></div><di=
v>On CentOS 7, python-itsdangerous-0.23-2.<wbr>el7.noarch is available from=
 the @extras packages</div><div>On RHEL 7, python-itsdangerous-0.23-2.<wbr>=
el7.noarch is available from the @rhel-7-server-extras-rpms packages</div><=
div>Unfortunately, these are too low of a version.=C2=A0 I&#39;m guessing w=
e want to use the PGDG-built version.</div><div><br></div><div>I think that=
 these lines should actually now be moved to:</div><div>Requires: =C2=A0 =
=C2=A0 =C2=A0 pgadmin4-python-itsdangerous &gt;=3D 0.24<br></div><div><br><=
/div><div>Is that a correct assumption?</div><div><br></div><div><br></div>=
<div>After making those two modifications (and ignoring the patchfile, whic=
h I&#39;m investigating), I am able to build and install pgadmin4 successfu=
lly with the new specfile, which is pretty awesome.</div><div><br></div><di=
v>Thanks!</div><div>=C2=A0 -John</div></div></div></div>

--001a113ddb94b7570d054e3f99d4--