Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7jur-0005Gp-9G for pgsql-pkg-yum@arkaria.postgresql.org; Mon, 08 May 2017 14:45:37 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d7juq-0002Ki-K8 for pgsql-pkg-yum@arkaria.postgresql.org; Mon, 08 May 2017 14:45:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d7jum-0002EG-Hr for pgsql-pkg-yum@postgresql.org; Mon, 08 May 2017 14:45:32 +0000 Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d7jue-0005E9-Pb for pgsql-pkg-yum@postgresql.org; Mon, 08 May 2017 14:45:32 +0000 Received: by mail-oi0-x22e.google.com with SMTP id b204so52865730oii.1 for ; Mon, 08 May 2017 07:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crunchydata-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=x4Bf57Ln97TPQM8b9Pzj+jpP9WnvjCTH0OOZTnH6+iU=; b=UCxZsPnKVhd2sBVsBjksQtHeYElrHMbVCt6nJT68RR5ggKTJGwskiSnEShcxdCaiPe DvT3Lndd1M6KJkY9nGw5sr2fX3G0/BQaagKhm1LQDerwDiI1KtOwwg4oZbYX0fQrPgGW l+LkN2wXOEB2e8ygSLDkpZ9HFL6Ike84cFop8E6QVcnqLybLyLYgE7bUmj1Rj+oyUuow zUlC8DmAz5P3RfLTb96Z+xcRYjpbmQSKJmzhuSi4HuuVKveUIkwxMevDKDEAQKuy/Jls njeJyusG6e4nqcVsJkS6CoZE25bEc3qFHcwWiK4daypMZRZLYa/DmHXxzD8HXIj2hM8A Xrig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=x4Bf57Ln97TPQM8b9Pzj+jpP9WnvjCTH0OOZTnH6+iU=; b=qeZyIVM44jAEzHo6x5iASEO3OdBl0qch8t4+w6SjBNpckdjaRJSkTnQJaA+w4uAKko gqm0AB7YC+jC/sHPoU5w9orWgTJqA0WLkixwnpRNQ9flQqkkrTBZSsPlRpJgw3UT9ljL UCoD1Y5/9ZKYmRqIn6v4jVEaghyQATdLEU48r0GFGiwjDUfHuC8kISk2fHpL2CcY98cd rlwu8LZov8323BuDtsXcCqTyhTAATIoZtZ4zShEq6Y0oFKXkPwGdYVL//HmA0uybsnE3 DzioCikXg2gr7jB1TW2Om88hkQt1CumOCxEPbDfxlGqoUXOsA4JyNBX8smWwtw8dN61y 0mbQ== X-Gm-Message-State: AN3rC/6TMBhjJPmmm/iauI9itRpvZWZ7tZef/ml8Zs2Z95XG73rublaF hW/Rn0x+pF9QEni/cOn4AJTGE1jB0ep2 X-Received: by 10.157.61.52 with SMTP id a49mr25017735otc.30.1494254722072; Mon, 08 May 2017 07:45:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.115.69 with HTTP; Mon, 8 May 2017 07:44:41 -0700 (PDT) In-Reply-To: References: <1493289313.3032.46.camel@gunduz.org> <1493386507.11169.12.camel@gunduz.org> <1493541308.14590.2.camel@gunduz.org> From: John Harvey Date: Mon, 8 May 2017 10:44:41 -0400 Message-ID: Subject: Re: pgadmin4 RPM broken? To: pgsql-pkg-yum Content-Type: multipart/alternative; boundary=001a11409322e9dd1f054f0449ed X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --001a11409322e9dd1f054f0449ed Content-Type: text/plain; charset=UTF-8 Hi Devrim, It looks like all changes are in and work just fine. I also can't reproduce my patch-file issues anymore, so that's good too! I had one last finding today, based on your last set of commits from the weekend. I see that you've changed the python-flask dependencies in the pgadmin4 spec file to be pgadmin4-python-flask. I have no issue with that change, but for consistency, you may want to consider the following 2 modifications: 1) pgadmin4-python-flask-principal.spec Change: Requires: python-flask to: Requires: pgadmin4-python-flask 2) pgadmin4-python-flask-sqlalchemy.spec Change: BuildRequires: python-flask to: BuildRequires: pgadmin4-python-flask Regards, -John --001a11409322e9dd1f054f0449ed Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Devrim,

It looks like all changes ar= e in and work just fine.
I also can't reproduce my patch-file= issues anymore, so that's good too!

I had one= last finding today, based on your last set of commits from the weekend.
I see that you've changed the python-flask dependencies in the = pgadmin4 spec file to be pgadmin4-python-flask.

I = have no issue with that change, but for consistency, you may want to consid= er the following 2 modifications:

1) pgadmin4-pyth= on-flask-principal.spec

Change:
=C2= =A0 =C2=A0 Requires: =C2=A0 =C2=A0 =C2=A0python-flask
to:
=C2=A0 =C2=A0 Requires: =C2=A0 =C2=A0 =C2=A0pgadmin4-python-flask
<= /div>

2) pgadmin4-python-flask-sqlalchemy.spec

Change:
=C2=A0 =C2=A0 BuildRequires: =C2=A0python= -flask
to:
=C2=A0 =C2=A0 BuildRequires: =C2=A0= pgadmin4-python-flask

Regards,
=C2=A0 -John
--001a11409322e9dd1f054f0449ed--