Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b333r-0000Y3-Sq for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 18 May 2016 15:07:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b333r-0003BI-FY for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 18 May 2016 15:06:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b333n-00037k-Og for pgsql-pkg-yum@postgresql.org; Wed, 18 May 2016 15:06:55 +0000 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b333j-0001Zf-Li for pgsql-pkg-yum@postgresql.org; Wed, 18 May 2016 15:06:55 +0000 Received: by mail-lb0-x235.google.com with SMTP id ww9so18551737lbc.2 for ; Wed, 18 May 2016 08:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nordeus-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hBbtTDTXGWHTVPCWNsbyN2ezu8jvNOQ+IlU7Zby1QTo=; b=u+GZPDC+BHW62qfh+HghNQFTebZy+rBJqpytUi3HE1R/XXLfXVn8g4MTkL90X/iRep v2znfHhLW7NDBshi4zZxgYRcSub1lWzPWto1BzU41d3F72OYfWt4y8wj4wKPkrakXB/4 dcGo94U6MQg+4wqfs1AWXlbtTWooPl5aI5+LKZwvDlxZHeFzKj1zSOD/5x3zjjLX2hm5 4TmdkEco+emg9CJQE6XzKhyFraT9jqlZu7YG3yqlmOn2W5zDEBp9+YEavEJ80asZGrBa wYnoZvGL2O6wMOu2tD7QJ0CyiBnTkCv8zWT5rL8TlPThAdTdPCBKVx1xT6BLTpJPW4iY TJ8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hBbtTDTXGWHTVPCWNsbyN2ezu8jvNOQ+IlU7Zby1QTo=; b=MX4J7ou1SonkfRDD+WwRxsA0R1sqqPVvcFCstpm6al+MSRQNX2F+efJ/U9apYHPsO8 yhgfR7f6+Gqw/j9adlka3hq/1L7VUwVZWCg6UIfImOhUU3cj3cFBaBeSORqyU0hzKD63 Dw6RqQQtozm+Za/C/c/HQWKLZ2UFmFFL57TWu8kWGeCnl4wHrjm4Enn31aFpj+BHWbcC /EZ7kPpD4QV6plxW9HyplliXwW/Ndb9nJglN/vZFMmS5gyeqILOOtBNq74nj0Db3OfJD p3fvJGn5ZlRuPVqzpt/+rpppQcAwcjJAitK7THrAS3yPZzn9rGMIAYO9asAB50zQV8qK z36Q== X-Gm-Message-State: AOPr4FXrDJtj2erFjjU5Cm+ykYxxDBkRG39hdxQz/0JHmtfVrGF5xkSqEspK4udVx4LXn2vKRVeJcjwBUa3E0Hv1 X-Received: by 10.112.126.136 with SMTP id my8mr2481242lbb.22.1463584010265; Wed, 18 May 2016 08:06:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.174.141 with HTTP; Wed, 18 May 2016 08:06:30 -0700 (PDT) In-Reply-To: <6083A5D974AB434F31C6FF23@eje.credativ.lan> References: <0EDD19E44F05669CE0D68F45@eje.credativ.lan> <0AC9AAC9-0B01-47E3-860F-620C5F0912F1@pgexperts.com> <6BCC2B177DD8C95F954B4E1D@eje.credativ.lan> <1442584089.30698.43.camel@gunduz.org> <6083A5D974AB434F31C6FF23@eje.credativ.lan> From: =?UTF-8?Q?Strahinja_Kustudi=C4=87?= Date: Wed, 18 May 2016 17:06:30 +0200 Message-ID: Subject: Re: systemd service files vs. postgresql9x-setup To: Bernd Helmle Cc: =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= , Jeff Frost , pgsql-pkg-yum Content-Type: multipart/mixed; boundary=001a11c3799a08cd6d05331f3505 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --001a11c3799a08cd6d05331f3505 Content-Type: multipart/alternative; boundary=001a11c3799a08cd6605331f3503 --001a11c3799a08cd6605331f3503 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I propose the same patch with a modification to work with spaces in the path, since systemctl prints spaces as '\x20', so we just needed one more sed to replace that with a space. Would also like to see this fixed in the next minor release, since it makes it really hard to change PGDATA the correct way, which is by droping a .conf file into /etc/systemd/system/postgresql-9.x.service.d/ directory. Also would be really cool if the postgres rpm created the /etc/systemd/system/postgresql-9.x.service.d/ directory, but it's not that important as the setup scripts working correctly. Strahinja Kustudi=C4=87 | Lead System Engineer | Nordeus On Fri, Mar 11, 2016 at 1:01 PM, Bernd Helmle wrote: > > > --On 18. September 2015 16:48:09 +0300 Devrim G=C3=9CND=C3=9CZ > wrote: > > > First of all: Thanks for the patch! > > > > The next set of new minor releases are due in a few weeks. I think we > > can apply this patch then. > > > > (We need a issue tracker!) > > Hmm, i've totally forgotten that. I see that it's not committed yet, so i > just go forward and ask if there's something missing we need to address? > > -- > Thanks > > Bernd > > > -- > Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-pkg-yum > --001a11c3799a08cd6605331f3503 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I propose the same patch with a modification to= work with spaces in the path, since systemctl prints spaces as '\x20&#= 39;, so we just needed one more sed to replace that with a space.

Would also like to see this fixed in the next minor release, since it m= akes it really hard to change PGDATA the correct way, which is by droping a= .conf file into /etc/systemd/system/postgresql-9.x.service.d/ directory.
Also would be really cool if the postgres rpm created the /etc/= systemd/system/postgresql-9.x.service.d/ directory, but it's not that i= mportant as the setup scripts working correctly.


Strahinja Kustudi=C4=87 | Lead System Engineer | Nordeus

On Fri, Mar 11, 2016 at 1:01 PM, Bernd Helml= e <mailings@oopsware.de> wrote:


--On 18. September 2015 16:48:09 +0300 Devrim G=C3=9CND=C3=9CZ <devrim@gunduz.org>
wrote:

> First of all: Thanks for the patch!
>
> The next set of new minor releases are due in a few weeks. I think we<= br> > can apply this patch then.
>
> (We need a issue tracker!)

Hmm, i've totally forgotten that. I see that it's not commit= ted yet, so i
just go forward and ask if there's something missing we need to address= ?

--
Thanks

=C2=A0 =C2=A0 =C2=A0 =C2=A0 Bernd


--
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum=

--001a11c3799a08cd6605331f3503-- --001a11c3799a08cd6d05331f3505 Content-Type: text/x-patch; charset=US-ASCII; name="read-PGDATA-from-systemctl-and-space-in-path.patch" Content-Disposition: attachment; filename="read-PGDATA-from-systemctl-and-space-in-path.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ioczze8l0 ZGlmZiAtLWdpdCBhL3JwbS9yZWRoYXQvOS40L3Bvc3RncmVzcWwvRUwtNy9w b3N0Z3Jlc3FsOTQtc2V0dXAgYi9ycG0vcmVkaGF0LzkuNC9wb3N0Z3Jlc3Fs L0VMLTcvcG9zdGdyZXNxbDk0LXNldHVwCmluZGV4IDFmMGNiMGYuLjQ0Y2Mw OTAgMTAwNjQ0Ci0tLSBhL3JwbS9yZWRoYXQvOS40L3Bvc3RncmVzcWwvRUwt Ny9wb3N0Z3Jlc3FsOTQtc2V0dXAKKysrIGIvcnBtL3JlZGhhdC85LjQvcG9z dGdyZXNxbC9FTC03L3Bvc3RncmVzcWw5NC1zZXR1cApAQCAtNzMsMzYgKzcz LDIwIEBAIGNhc2UgIiQxIiBpbgogICAgICAgICA7OwogZXNhYwogCi0jIHRo aXMgcGFyc2luZyB0ZWNobmlxdWUgZmFpbHMgZm9yIFBHREFUQSBwYXRobmFt ZXMgY29udGFpbmluZyBzcGFjZXMsCi0jIGJ1dCB0aGVyZSdzIG5vdCBtdWNo IEkgY2FuIGRvIGFib3V0IGl0IGdpdmVuIHN5c3RlbWN0bCdzIG91dHB1dCBm b3JtYXQuLi4KIFBHREFUQT1gc3lzdGVtY3RsIHNob3cgLXAgRW52aXJvbm1l bnQgIiR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIiB8CiAgICAgICAgICAgICAg ICAgc2VkICdzL15FbnZpcm9ubWVudD0vLycgfCB0ciAnICcgJ1xuJyB8Ci0g ICAgICAgICAgICAgICAgc2VkIC1uICdzL15QR0RBVEE9Ly9wJyB8IHRhaWwg LW4gMWAKKyAgICAgICAgICAgICAgICBzZWQgLW4gJ3MvXlBHREFUQT0vL3An IHwgdGFpbCAtbiAxIHwKKwkJc2VkICdzL1xceDIwLyAvZydgICMgcmVwbGFj ZSAnXHgyMCcgd2l0aCBzcGFjZQogaWYgWyB4IiRQR0RBVEEiID0geCBdOyB0 aGVuCiAgICAgZWNobyAiZmFpbGVkIHRvIGZpbmQgUEdEQVRBIHNldHRpbmcg aW4gJHtTRVJWSUNFX05BTUV9LnNlcnZpY2UiCiAgICAgZXhpdCAxCiBmaQog Ci0jIEZpbmQgdGhlIHVuaXQgZmlsZSBmb3IgbmV3IHZlcnNpb24uCi1pZiBb IC1mICIvZXRjL3N5c3RlbWQvc3lzdGVtLyR7U0VSVklDRV9OQU1FfS5zZXJ2 aWNlIiBdCi10aGVuCi0gICAgU0VSVklDRV9GSUxFPSIvZXRjL3N5c3RlbWQv c3lzdGVtLyR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIgotZWxpZiBbIC1mICIv bGliL3N5c3RlbWQvc3lzdGVtLyR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIiBd Ci10aGVuCi0gICAgU0VSVklDRV9GSUxFPSIvbGliL3N5c3RlbWQvc3lzdGVt LyR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIgotZWxzZQotICAgIGVjaG8gIkNv dWxkIG5vdCBmaW5kIHN5c3RlbWQgdW5pdCBmaWxlICR7U0VSVklDRV9OQU1F fS5zZXJ2aWNlIgotICAgIGV4aXQgMQotZmkKLQogIyBMb2cgZmlsZSBmb3Ig cGdfdXBncmFkZQogUEdVUExPRz0vdmFyL2xpYi9wZ3NxbC8kUEdNQUpPUlZF UlNJT04vcGd1cGdyYWRlLmxvZwogIyBMb2cgZmlsZSBmb3IgaW5pdGRiCiBQ R0xPRz0vdmFyL2xpYi9wZ3NxbC85LjQvaW5pdGRiLmxvZwogCi0jIEdldCBk YXRhIGRpcmVjdG9yeSBmcm9tIHRoZSBzZXJ2aWNlIGZpbGUKLVBHREFUQT1g c2VkIC1uICdzL0Vudmlyb25tZW50PVBHREFUQT0vL3AnICIke1NFUlZJQ0Vf RklMRX0iYAotCiBleHBvcnQgUEdEQVRBCiAKICMgRm9yIFNFTGludXggd2Ug bmVlZCB0byB1c2UgJ3J1bnVzZXInIG5vdCAnc3UnCmRpZmYgLS1naXQgYS9y cG0vcmVkaGF0LzkuNS9wb3N0Z3Jlc3FsL0VMLTcvcG9zdGdyZXNxbDk1LXNl dHVwIGIvcnBtL3JlZGhhdC85LjUvcG9zdGdyZXNxbC9FTC03L3Bvc3RncmVz cWw5NS1zZXR1cAppbmRleCA2OTdlMGI0Li5jNjhhMWEzIDEwMDY0NAotLS0g YS9ycG0vcmVkaGF0LzkuNS9wb3N0Z3Jlc3FsL0VMLTcvcG9zdGdyZXNxbDk1 LXNldHVwCisrKyBiL3JwbS9yZWRoYXQvOS41L3Bvc3RncmVzcWwvRUwtNy9w b3N0Z3Jlc3FsOTUtc2V0dXAKQEAgLTczLDM2ICs3MywyMCBAQCBjYXNlICIk MSIgaW4KICAgICAgICAgOzsKIGVzYWMKIAotIyB0aGlzIHBhcnNpbmcgdGVj aG5pcXVlIGZhaWxzIGZvciBQR0RBVEEgcGF0aG5hbWVzIGNvbnRhaW5pbmcg c3BhY2VzLAotIyBidXQgdGhlcmUncyBub3QgbXVjaCBJIGNhbiBkbyBhYm91 dCBpdCBnaXZlbiBzeXN0ZW1jdGwncyBvdXRwdXQgZm9ybWF0Li4uCiBQR0RB VEE9YHN5c3RlbWN0bCBzaG93IC1wIEVudmlyb25tZW50ICIke1NFUlZJQ0Vf TkFNRX0uc2VydmljZSIgfAogICAgICAgICAgICAgICAgIHNlZCAncy9eRW52 aXJvbm1lbnQ9Ly8nIHwgdHIgJyAnICdcbicgfAotICAgICAgICAgICAgICAg IHNlZCAtbiAncy9eUEdEQVRBPS8vcCcgfCB0YWlsIC1uIDFgCisgICAgICAg ICAgICAgICAgc2VkIC1uICdzL15QR0RBVEE9Ly9wJyB8IHRhaWwgLW4gMSB8 CisJCXNlZCAncy9cXHgyMC8gL2cnYCAjIHJlcGxhY2UgJ1x4MjAnIHdpdGgg c3BhY2UKIGlmIFsgeCIkUEdEQVRBIiA9IHggXTsgdGhlbgogICAgIGVjaG8g ImZhaWxlZCB0byBmaW5kIFBHREFUQSBzZXR0aW5nIGluICR7U0VSVklDRV9O QU1FfS5zZXJ2aWNlIgogICAgIGV4aXQgMQogZmkKIAotIyBGaW5kIHRoZSB1 bml0IGZpbGUgZm9yIG5ldyB2ZXJzaW9uLgotaWYgWyAtZiAiL2V0Yy9zeXN0 ZW1kL3N5c3RlbS8ke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIgXQotdGhlbgot ICAgIFNFUlZJQ0VfRklMRT0iL2V0Yy9zeXN0ZW1kL3N5c3RlbS8ke1NFUlZJ Q0VfTkFNRX0uc2VydmljZSIKLWVsaWYgWyAtZiAiL2xpYi9zeXN0ZW1kL3N5 c3RlbS8ke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIgXQotdGhlbgotICAgIFNF UlZJQ0VfRklMRT0iL2xpYi9zeXN0ZW1kL3N5c3RlbS8ke1NFUlZJQ0VfTkFN RX0uc2VydmljZSIKLWVsc2UKLSAgICBlY2hvICJDb3VsZCBub3QgZmluZCBz eXN0ZW1kIHVuaXQgZmlsZSAke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIKLSAg ICBleGl0IDEKLWZpCi0KICMgTG9nIGZpbGUgZm9yIHBnX3VwZ3JhZGUKIFBH VVBMT0c9L3Zhci9saWIvcGdzcWwvJFBHTUFKT1JWRVJTSU9OL3BndXBncmFk ZS5sb2cKICMgTG9nIGZpbGUgZm9yIGluaXRkYgogUEdMT0c9L3Zhci9saWIv cGdzcWwvOS41L2luaXRkYi5sb2cKIAotIyBHZXQgZGF0YSBkaXJlY3Rvcnkg ZnJvbSB0aGUgc2VydmljZSBmaWxlCi1QR0RBVEE9YHNlZCAtbiAncy9FbnZp cm9ubWVudD1QR0RBVEE9Ly9wJyAiJHtTRVJWSUNFX0ZJTEV9ImAKLQogZXhw b3J0IFBHREFUQQogCiAjIEZvciBTRUxpbnV4IHdlIG5lZWQgdG8gdXNlICdy dW51c2VyJyBub3QgJ3N1Jwo= --001a11c3799a08cd6d05331f3505 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-pkg-yum --001a11c3799a08cd6d05331f3505--