MIME-Version: 1.0
References: 
 <CAECtzeUZbumKL8SBBUP_HdRVsNStxv1u0Uh9xy1XrpO-ixfBxQ@mail.gmail.com>
 <10825c6f2aff7e0c4db7fef45f4b25132b2735c1.camel@gunduz.org>
In-Reply-To: <10825c6f2aff7e0c4db7fef45f4b25132b2735c1.camel@gunduz.org>
From: Guillaume Lelarge <guillaume@lelarge.info>
Date: Fri, 20 Oct 2023 14:43:42 +0200
Message-ID: 
 <CAECtzeVSU6WWwgK5P40pSZ4eWw6susv=_0PR5jzTyiAAx=fk+w@mail.gmail.com>
Subject: Re:
To: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>
Cc: pgsql-pkg-yum <pgsql-pkg-yum@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000099d5ba0608253928"
Archived-At: 
 <https://www.postgresql.org/message-id/CAECtzeVSU6WWwgK5P40pSZ4eWw6susv%3D_0PR5jzTyiAAx%3Dfk%2Bw%40mail.gmail.com>
Precedence: bulk

--00000000000099d5ba0608253928
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Devrim,

First, sorry for the email with no subject. I guess I was in a hurry :)

Le ven. 20 oct. 2023 =C3=A0 08:59, Devrim G=C3=BCnd=C3=BCz <devrim@gunduz.o=
rg> a =C3=A9crit :

> Hi Guillaume,
>
> On Thu, 2023-10-19 at 19:51 +0200, Guillaume Lelarge wrote:
> > From rpm/redhat/15/postgresql-15/EL-9/postgresql-15.spec (and many
> > other
> > postgresql .spec files):
> >
> > # These file(s) should not be packaged:
> >
> > %{__rm} %{buildroot}%{pgbaseinstdir}/lib/libpgfeutils.a
> >
> > I'm wondering why this library shouldn't be packaged? It is definitely
> > useful for front-end clients.
>
> This is per Fedora packaging guidelines:
>
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-stat=
ic-libraries
>
> ...though it is a "should not" item. OTOH, the same guideline if we says
> we need to split those files under  -static subpackage, which we don't
> ship right now.
>
>
OK, I guess it makes sense.


> Just took a look at Fedora spec file, and they already ship these files
> in -static subpackage (we ship them with -devel subpackage as of now)
>
> libpgcommon.a
> libpgcommon_shlib.a
> libpgport.a
> libpgport_shlib.a
>
> but not libpgfeutils.a
>
>
Yeah, I saw that. I stll don't get why we ship libpgcommon static library,
but not libpgutils.


--=20
Guillaume.

--00000000000099d5ba0608253928
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Devrim,</div><div dir=3D"ltr"><br></di=
v><div dir=3D"ltr">First, sorry for the email with no subject. I guess I wa=
s in a hurry :)<br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" cl=
ass=3D"gmail_attr">Le=C2=A0ven. 20 oct. 2023 =C3=A0=C2=A008:59, Devrim G=C3=
=BCnd=C3=BCz &lt;<a href=3D"mailto:devrim@gunduz.org" target=3D"_blank">dev=
rim@gunduz.org</a>&gt; a =C3=A9crit=C2=A0:<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex">Hi Guillaume,<br>
<br>
On Thu, 2023-10-19 at 19:51 +0200, Guillaume Lelarge wrote:<br>
&gt; From rpm/redhat/15/postgresql-15/EL-9/postgresql-15.spec (and many<br>
&gt; other<br>
&gt; postgresql .spec files):<br>
&gt; <br>
&gt; # These file(s) should not be packaged:<br>
&gt; <br>
&gt; %{__rm} %{buildroot}%{pgbaseinstdir}/lib/libpgfeutils.a<br>
&gt; <br>
&gt; I&#39;m wondering why this library shouldn&#39;t be packaged? It is de=
finitely<br>
&gt; useful for front-end clients.<br>
<br>
This is per Fedora packaging guidelines:<br>
<br>
<a href=3D"https://docs.fedoraproject.org/en-US/packaging-guidelines/#packa=
ging-static-libraries" rel=3D"noreferrer" target=3D"_blank">https://docs.fe=
doraproject.org/en-US/packaging-guidelines/#packaging-static-libraries</a><=
br>
<br>
...though it is a &quot;should not&quot; item. OTOH, the same guideline if =
we says<br>
we need to split those files under=C2=A0 -static subpackage, which we don&#=
39;t<br>
ship right now.<br>
<br></blockquote><div><br></div><div>OK, I guess it makes sense.</div><div>=
=C2=A0<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Just took a look at Fedora spec file, and they already ship these files<br>
in -static subpackage (we ship them with -devel subpackage as of now)<br>
<br>
libpgcommon.a<br>
libpgcommon_shlib.a<br>
libpgport.a<br>
libpgport_shlib.a<br>
<br>
but not libpgfeutils.a<br>
<br></blockquote><div><br></div><div>Yeah, I saw that. I stll don&#39;t get=
 why we ship libpgcommon static library, but not libpgutils.</div></div><di=
v><br></div><div><br></div><span class=3D"gmail_signature_prefix">-- </span=
><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div><div =
dir=3D"ltr"><div>Guillaume.<br></div></div></div></div></div></div>

--00000000000099d5ba0608253928--