MIME-Version: 1.0
References: <20201105190206.4358b61d@firost>
 <CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
In-Reply-To: 
 <CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
From: Craig Ringer <craig.ringer@enterprisedb.com>
Date: Mon, 9 Nov 2020 10:33:07 +0800
Message-ID: 
 <CAGRY4nwOVh8JayrjLE98UFF-jUODapQ-k2Lvgu=FGTz4Xa9x-g@mail.gmail.com>
Subject: Re: missing perl test modules in postgresqlXX-devel ?
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: pgsql-pkg-yum@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000920bdf05b3a36292"
Precedence: bulk

--000000000000920bdf05b3a36292
Content-Type: text/plain; charset="UTF-8"

Looking at the web, I can find old memories [1] where postgresql12-devel
>> installed them in /usr/pgsql-12/lib/pgxs/src/test/perl/
>>
>
> We really need some consistency and cross checks between the RPMs and debs.
>

Ah. I just noticed you said they're installed with the *client* packages.

So that's an example of how we actually need some postgres packaging
guidance that applies to rpms, debs, EDB's binary installers, and anything
else, separate to any particular packaging method or team.

In this case I think it's a bit silly to put the test perl modules along
with the client. They can't really be used without the server installed,
and they're not useful for much unless you're building extensions. They
should be in a -dev package IMO. They should preferably not be in the test
package along with the actual test input files, though, since they're used
by extensions to run their own tests and extensions only have to depend on
server-dev not on a -test package.

Anyway, I hope the above answers your questions about where they live.

--000000000000920bdf05b3a36292
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"></div><div class=3D"gmail_quote"><br><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left=
:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=
=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Looking =
at the web, I can find old memories [1] where postgresql12-devel<br>
installed them in /usr/pgsql-12/lib/pgxs/src/test/perl/<br></blockquote><di=
v><br></div><div>We really need some consistency and cross checks between t=
he RPMs and debs.</div></div></div></blockquote><div><br></div><div>Ah. I j=
ust noticed you said they&#39;re installed with the *client* packages.</div=
><div><br></div><div>So that&#39;s an example of how we actually need some =
postgres packaging guidance that applies to rpms, debs, EDB&#39;s binary in=
stallers, and anything else, separate to any particular packaging method or=
 team.</div><div><br></div><div>In this case I think it&#39;s a bit silly t=
o put the test perl modules along with the client. They can&#39;t really be=
 used without the server installed, and they&#39;re not useful for much unl=
ess you&#39;re building extensions. They should be in a -dev package IMO. T=
hey should preferably not be in the test package along with the actual test=
 input files, though, since they&#39;re used by extensions to run their own=
 tests and extensions only have to depend on server-dev not on a -test pack=
age.</div><div><br></div><div>Anyway, I hope the above answers your questio=
ns about where they live.<br></div></div></div>

--000000000000920bdf05b3a36292--