public inbox for [email protected]
help / color / mirror / Atom feedFrom: Craig Ringer <[email protected]>
To: Jehan-Guillaume de Rorthais <[email protected]>
Cc: [email protected]
Subject: Re: missing perl test modules in postgresqlXX-devel ?
Date: Fri, 13 Nov 2020 13:38:05 +0800
Message-ID: <CAGRY4nwhfqJm=fqwhkhqK8u=2FxS+m4h2HNLNtp8bKS=MQ-hyA@mail.gmail.com> (raw)
In-Reply-To: <20201112113632.627b8749@firost>
References: <20201105190206.4358b61d@firost>
<CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
<20201109114034.2cc8aab5@firost>
<CAGRY4nz+xcczzYXVuNva8=r+ucgp5pYMt0_eM-nBv4iPNCmyKw@mail.gmail.com>
<20201110145627.07954db0@firost>
<CAGRY4nxwwyxMCcWaSZMRm+opbd5sVVtzhXaPNqvvTpzEYZE6RQ@mail.gmail.com>
<20201112113632.627b8749@firost>
On Thu, Nov 12, 2020 at 6:36 PM Jehan-Guillaume de Rorthais <[email protected]>
wrote:
> I fired the vagrant generic/rhel7 box and registered it using my dev
> account:
>
>
Thanks.
Note that the package came from rhel-7-server-rpms:
>
> $ sudo yum history packages-info perl-Test-Simple|grep ^From
> From repo : rhel-7-server-rpms
>
> RHEL official documentation confirm the package is available in base
> repository:
>
>
> https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/package_manifest/packa...
>
>
Based on this, I think it's appropriate to modify the EL-7 spec file for
all Pg versions (example patch is for -10) something like the following.
Note that I removed a duplicate guard for "&& 0%{?suse_version} >= 1315"
where the test for "enabletaptests" already excluded that. And I made sure
that both fedora and rhel require both IPC::Run and Test::More ; I don't
see why that was ever not be the case.
--- a/rpm/redhat/master/non-common/postgresql-10/master/postgresql-10.spec
+++ b/rpm/redhat/master/non-common/postgresql-10/master/postgresql-10.spec
@@ -12,7 +12,7 @@
%{!?kerbdir:%global kerbdir "/usr"}
%{!?disablepgfts:%global disablepgfts 0}
-%if 0%{?rhel} || 0%{?suse_version} >= 1315
+%if (0%{?rhel} && 0%{?rhel} <= 6) || 0%{?suse_version} >= 1315
%{!?enabletaptests:%global enabletaptests 0}
%else
%{!?enabletaptests:%global enabletaptests 1}
@@ -367,17 +367,13 @@ Requires: libicu-devel
%endif
%if %enabletaptests
-%if 0%{?suse_version} && 0%{?suse_version} >= 1315
+%if 0%{?suse_version}
Requires: perl-IPC-Run
BuildRequires: perl-IPC-Run
%endif
-%if 0%{?rhel} && 0%{?rhel} <= 7
-Requires: perl-Test-Simple
-BuildRequires: perl-Test-Simple
-%endif
-%if 0%{?fedora}
-Requires: perl-IPC-Run
-BuildRequires: perl-IPC-Run
+%if 0%{?rhel} || 0%{?fedora}
+Requires: perl(Test::More) perl(IPC::Run)
+BuildRequires: perl(Test::More) perl(IPC::Run)
%endif
%endif
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: missing perl test modules in postgresqlXX-devel ?
In-Reply-To: <CAGRY4nwhfqJm=fqwhkhqK8u=2FxS+m4h2HNLNtp8bKS=MQ-hyA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox