MIME-Version: 1.0
References: <20201105190206.4358b61d@firost>
 <CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
 <20201109114034.2cc8aab5@firost>
In-Reply-To: <20201109114034.2cc8aab5@firost>
From: Craig Ringer <craig.ringer@enterprisedb.com>
Date: Tue, 10 Nov 2020 13:57:22 +0800
Message-ID: 
 <CAGRY4nz+xcczzYXVuNva8=r+ucgp5pYMt0_eM-nBv4iPNCmyKw@mail.gmail.com>
Subject: Re: missing perl test modules in postgresqlXX-devel ?
To: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: pgsql-pkg-yum@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000e63c9605b3ba5a52"
Precedence: bulk

--000000000000e63c9605b3ba5a52
Content-Type: text/plain; charset="UTF-8"

On Mon, Nov 9, 2020 at 6:40 PM Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
wrote:

>
> So it looks like at least EL7 packages are broken/different from fedora
> 32. Here
> are some more informations from a CentOS Linux 7 (vagrant box "centos/7"):
>
>   # repoquery -f /usr/pgsql-12/bin/postgres
>   postgresql12-server-0:12.2-1PGDG.rhel7.x86_64
>   postgresql12-server-0:12.1-2PGDG.rhel7.x86_64
>   postgresql12-server-0:12.2-2PGDG.rhel7.x86_64
>   postgresql12-server-0:12.3-1PGDG.rhel7.x86_64
>   postgresql12-server-0:12.3-5PGDG.rhel7.x86_64
>   postgresql12-server-0:12.4-1PGDG.rhel7.x86_64
>
>   # repoquery -f /usr/pgsql-13/bin/postgres
>   postgresql13-server-0:13.0-1PGDG.rhel7.x86_64
>
>   # repoquery -f /usr/pgsql-12/lib/pgxs/src/test/perl/PostgresNode.pm
>   (nothing)
>
>   # repoquery -f /usr/pgsql-13/lib/pgxs/src/test/perl/PostgresNode.pm
>   (nothing)
>

Yeah, that seems wrong.

You can find concrete (non-symlink) spec files for current releases with:

     find -type f -regex '.*/postgresql-\(9\.[456]\|1[0-9]\).spec'

e.g.

    rpm/redhat/master/non-common/postgresql-13/master/postgresql-13.spec

You'll note that while they're shared across distro variants, there's a
separate specfile for each major release.

In rpm/redhat/master/non-common/postgresql-13/master/postgresql-13.spec
you'll see

    %files devel -f pg_devel.lst
    ....
    %{pgbaseinstdir}/lib/pgxs/*
    ....

so anything installed in pgxs/* should be packaged.

TAP tests get installed if they are enabled. They are enabled if
--enable-tap-tests is passed to configure. That is controlled by the stanza

    %if %enabletaptests
            --enable-tap-tests \
    %endif

which in turn is controlled by

    %if 0%{?rhel} || 0%{?suse_version} >= 1315
    %{!?enabletaptests:%global enabletaptests 0}
    %else
    %{!?enabletaptests:%global enabletaptests 1}
    %endif

so apparently the TAP tests aren't built/enabled for any RHEL/CentOS
versions in -13. The same is true for 10 and up, at least.

That's ... surprising. There's no comment to indicate why.

Git logs suggest the cause is commit 511834297 "Disable tap tests  on RHEL
7" . I think the package in question is perl-Test-Simple a.k.a
'perl(Test::Simple)'.

It looks like the test should be updated to enable them for RHEL 8 at least.

I don't really feel like wrestling builds for an obsolete OS version to get
these packaged for EL-7 though.

--000000000000e63c9605b3ba5a52
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=3D"gmail_quote"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Mon, Nov 9, 2020 at 6:40 PM Jehan-Guil=
laume de Rorthais &lt;<a href=3D"mailto:jgdr@dalibo.com" target=3D"_blank">=
jgdr@dalibo.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" s=
tyle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pad=
ding-left:1ex"><br>
So it looks like at least EL7 packages are broken/different from fedora 32.=
 Here<br>
are some more informations from a CentOS Linux 7 (vagrant box &quot;centos/=
7&quot;):<br>
<br>
=C2=A0 # repoquery -f /usr/pgsql-12/bin/postgres<br>
=C2=A0 postgresql12-server-0:12.2-1PGDG.rhel7.x86_64<br>
=C2=A0 postgresql12-server-0:12.1-2PGDG.rhel7.x86_64<br>
=C2=A0 postgresql12-server-0:12.2-2PGDG.rhel7.x86_64<br>
=C2=A0 postgresql12-server-0:12.3-1PGDG.rhel7.x86_64<br>
=C2=A0 postgresql12-server-0:12.3-5PGDG.rhel7.x86_64<br>
=C2=A0 postgresql12-server-0:12.4-1PGDG.rhel7.x86_64<br>
<br>
=C2=A0 # repoquery -f /usr/pgsql-13/bin/postgres<br>
=C2=A0 postgresql13-server-0:13.0-1PGDG.rhel7.x86_64<br>
<br>
=C2=A0 # repoquery -f /usr/pgsql-12/lib/pgxs/src/test/perl/PostgresNode.pm<=
br>
=C2=A0 (nothing)<br>
<br>
=C2=A0 # repoquery -f /usr/pgsql-13/lib/pgxs/src/test/perl/PostgresNode.pm<=
br>
=C2=A0 (nothing)<br></blockquote><div><br></div><div>Yeah, that seems wrong=
.</div><div><br></div><div>You can find concrete (non-symlink) spec files f=
or current releases with:<br></div></div><div class=3D"gmail_quote"><br><di=
v>=C2=A0=C2=A0=C2=A0=C2=A0 find -type f -regex &#39;.*/postgresql-\(9\.[456=
]\|1[0-9]\).spec&#39;<br></div><div><br></div><div>e.g.</div><div><br></div=
><div>=C2=A0=C2=A0=C2=A0 rpm/redhat/master/non-common/postgresql-13/master/=
postgresql-13.spec</div></div><div class=3D"gmail_quote"><br></div><div cla=
ss=3D"gmail_quote">You&#39;ll note that while they&#39;re shared across dis=
tro variants, there&#39;s a separate specfile for each major release.<br></=
div><div class=3D"gmail_quote"><div><br></div><div>In rpm/redhat/master/non=
-common/postgresql-13/master/postgresql-13.spec you&#39;ll see</div><div><b=
r></div><div>=C2=A0=C2=A0=C2=A0 %files devel -f pg_devel.lst</div><div>=C2=
=A0=C2=A0=C2=A0 ....<br></div><div>=C2=A0=C2=A0=C2=A0 %{pgbaseinstdir}/lib/=
pgxs/*<br></div></div><div class=3D"gmail_quote">=C2=A0=C2=A0=C2=A0 ....</d=
iv><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">so anyth=
ing installed in pgxs/* should be packaged. <br></div><div class=3D"gmail_q=
uote"><br></div><div class=3D"gmail_quote">TAP tests get installed if they =
are enabled. They are enabled if --enable-tap-tests is passed to configure.=
 That is controlled by the stanza</div><div class=3D"gmail_quote"><br></div=
><div class=3D"gmail_quote">=C2=A0=C2=A0=C2=A0 %if %enabletaptests<br>=C2=
=A0=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0 --enable-tap-tests \<br>=C2=A0=
=C2=A0=C2=A0 %endif<br></div><div class=3D"gmail_quote"><br></div><div clas=
s=3D"gmail_quote">which in turn is controlled by</div><div class=3D"gmail_q=
uote"><br></div><div class=3D"gmail_quote">=C2=A0=C2=A0=C2=A0 %if 0%{?rhel}=
 || 0%{?suse_version} &gt;=3D 1315<br>=C2=A0=C2=A0=C2=A0 %{!?enabletaptests=
:%global enabletaptests 0}<br>=C2=A0=C2=A0=C2=A0 %else<br>=C2=A0=C2=A0=C2=
=A0 %{!?enabletaptests:%global enabletaptests 1}<br>=C2=A0=C2=A0=C2=A0 %end=
if</div><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">so =
apparently the TAP tests aren&#39;t built/enabled for any RHEL/CentOS versi=
ons in -13. The same is true for 10 and up, at least.<br></div><div class=
=3D"gmail_quote"><br></div><div class=3D"gmail_quote">That&#39;s ... surpri=
sing. There&#39;s no comment to indicate why.</div><div class=3D"gmail_quot=
e"><br></div><div class=3D"gmail_quote">Git logs suggest the cause is commi=
t 511834297 &quot;Disable tap tests =C2=A0on RHEL 7&quot; . I think the pac=
kage in question is perl-Test-Simple a.k.a &#39;perl(Test::Simple)&#39;.<br=
></div><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">It l=
ooks like the test should be updated to enable them for RHEL 8 at least.</d=
iv><div class=3D"gmail_quote"><br></div><div class=3D"gmail_quote">I don=
9;t really feel like wrestling builds for an obsolete OS version to get the=
se packaged for EL-7 though.<br></div></div>

--000000000000e63c9605b3ba5a52--