public inbox for [email protected]help / color / mirror / Atom feed
Skytools for 10 — RPM missing 8+ messages / 3 participants [nested] [flat]
* Skytools for 10 — RPM missing @ 2017-12-13 20:16 Victor Yegorov <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Victor Yegorov @ 2017-12-13 20:16 UTC (permalink / raw) To: pgsql-pkg-yum Greetings. skytools package is missing from the PGDG 10 yum repository. Still, in the source tree I can see `spec` file: rpm/redhat/master/skytools/EL-7/skytools-10.init Is it possible to include this RPM into the repo, please? -- Victor Yegorov ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2017-12-13 21:17 Devrim Gündüz <[email protected]> parent: Victor Yegorov <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Devrim Gündüz @ 2017-12-13 21:17 UTC (permalink / raw) To: Victor Yegorov <[email protected]>; pgsql-pkg-yum Hi, On Wed, 2017-12-13 at 22:16 +0200, Victor Yegorov wrote: > skytools package is missing from the PGDG 10 yum repository. > > Still, in the source tree I can see `spec` file: > rpm/redhat/master/skytools/EL-7/skytools-10.init > > Is it possible to include this RPM into the repo, please? Skytools does not compile against Postgres 10. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2017-12-14 09:58 Christoph Berg <[email protected]> parent: Devrim Gündüz <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Christoph Berg @ 2017-12-14 09:58 UTC (permalink / raw) To: Devrim Gündüz <[email protected]>; +Cc: Victor Yegorov <[email protected]>; pgsql-pkg-yum Re: Devrim Gündüz 2017-12-13 <[email protected]> > > skytools package is missing from the PGDG 10 yum repository. > > > > Still, in the source tree I can see `spec` file: > > rpm/redhat/master/skytools/EL-7/skytools-10.init > > > > Is it possible to include this RPM into the repo, please? > > Skytools does not compile against Postgres 10. On the Debian side, we started moving to the split packages from https://github.com/pgq . Unfortunately, there's a whole bunch of them, and we have only packaged pgq and pgqd yet. The whole thing there looks like a big mess :( Christoph ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2017-12-15 13:17 Victor Yegorov <[email protected]> parent: Christoph Berg <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Victor Yegorov @ 2017-12-15 13:17 UTC (permalink / raw) To: Christoph Berg <[email protected]>; Devrim Gündüz <[email protected]>; Victor Yegorov <[email protected]>; pgsql-pkg-yum 2017-12-14 11:58 GMT+02:00 Christoph Berg <[email protected]>: > > On the Debian side, we started moving to the split packages from > https://github.com/pgq . Unfortunately, there's a whole bunch of them, > and we have only packaged pgq and pgqd yet. The whole thing there > looks like a big mess :( > Indeed. I've looked into the build process, things are crashing on `sql/txid/txid.c` for me: txid.c: In function 'txid_current_snapshot': txid.c:207:6: error: 'SerializableSnapshot' undeclared (first use in this function) if (SerializableSnapshot == NULL) ^ Poking around git on `git log -S SerializableSnapshot` and `git log -- contrib/txid/txid.c` I can see, that stuff from `skytools` to expose snapshots had been integrated into core years ago (commit 18e3fcc). Looking at the `sql/txid/Makefile`, they do nothing for that directory if we're on 8.3+. Versions checks stopped working on 10: -bash-4.2$ export PGVER=10.1 -bash-4.2$ test $PGVER "<" "8.3" && echo "false" || echo "true" false -bash-4.2$ export PGVER=9.6.6 -bash-4.2$ test $PGVER "<" "8.3" && echo "false" || echo "true" true I assume that this subdirectory can be excluded from the `Makefile`, 8.3 EOL came years ago. Doing so makes things compile fine for me. Patch is as simple as: diff --git a/rpm/redhat/master/skytools/master/skytools.spec b/rpm/redhat/master/skytools/master/skytools.spec index dbdb423..bda4715 100644 --- a/rpm/redhat/master/skytools/master/skytools.spec +++ b/rpm/redhat/master/skytools/master/skytools.spec @@ -58,6 +58,7 @@ rmdir lib %if %{pgmajorversion} != 92 sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' sql/pgq/triggers/stringutil.c %endif +sed -ie '/^SUBDIRS/s:ticker txid$:ticker:' sql/Makefile ./autogen.sh %configure --with-pgconfig=%{pginstdir}/bin/pg_config --with-asciidoc Devrim, do you think it's possible to add this change and add `skytools` to 10 repo? -- Victor Yegorov ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2017-12-15 16:35 Devrim Gündüz <[email protected]> parent: Victor Yegorov <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Devrim Gündüz @ 2017-12-15 16:35 UTC (permalink / raw) To: Victor Yegorov <[email protected]>; Christoph Berg <[email protected]>; pgsql-pkg-yum Hi, On Fri, 2017-12-15 at 15:17 +0200, Victor Yegorov wrote: > Devrim, do you think it's possible to add this change and add `skytools` to > 10 repo? I have no idea whether this patch may break other parts of Skytools or not, so not sure. Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2017-12-18 19:17 Victor Yegorov <[email protected]> parent: Devrim Gündüz <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Victor Yegorov @ 2017-12-18 19:17 UTC (permalink / raw) To: Devrim Gündüz <[email protected]>; +Cc: Christoph Berg <[email protected]>; pgsql-pkg-yum 2017-12-15 18:35 GMT+02:00 Devrim Gündüz <[email protected]>: > > I have no idea whether this patch may break other parts of Skytools or > not, so > not sure. I see. I've made another change than, that fixes PG version detection in the sql/txid/Makefile. With this patch I got `skytools` build fine here. -- Victor Yegorov --- a/rpm/redhat/master/skytools/master/skytools.spec +++ b/rpm/redhat/master/skytools/master/skytools.spec @@ -12,7 +12,7 @@ Summary: PostgreSQL database management tools from Skype Name: %{sname}-%{pgmajorversion} Version: 3.2.6 -Release: 1%{?dist} +Release: 2%{?dist} License: BSD Group: Applications/Databases Source0: https://github.com/markokr/%{sname}/archive/%{version}.tar.gz @@ -58,6 +58,8 @@ rmdir lib %if %{pgmajorversion} != 92 sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' sql/pgq/triggers/stringutil.c %endif +sed -ie '/^pg83/s:shell test.*$:shell [ $( echo -e "$PGVER\\n8.3"|sort -gt. -k1 -k2|head -n1 ) = $PGVER ] \&\& echo false || echo true):' sql/txid/Makefile +sed -ie '/^pg82/s:shell test.*$:shell [ $( echo -e "$PGVER\\n8.2"|sort -gt. -k1 -k2|head -n1 ) = $PGVER ] \&\& echo false || echo true):' sql/txid/Makefile ./autogen.sh %configure --with-pgconfig=%{pginstdir}/bin/pg_config --with-asciidoc @@ -189,6 +191,9 @@ sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' %{pginstdir}/share/contrib/pgq_triggers.sql %changelog +* Mon Dec 18 2017 Victor Yegorov <[email protected]> - 3.2.6-2 +- Fix sql/txid/Makefile for new versioning scheme + * Wed Sep 28 2016 Victor Yegorov <[email protected]> - 3.2.6-1 - Update to 3.2.6 Attachments: [text/plain] 20171218-skytools-10.diff (1.4K, 3-20171218-skytools-10.diff) download | inline diff: --- a/rpm/redhat/master/skytools/master/skytools.spec +++ b/rpm/redhat/master/skytools/master/skytools.spec @@ -12,7 +12,7 @@ Summary: PostgreSQL database management tools from Skype Name: %{sname}-%{pgmajorversion} Version: 3.2.6 -Release: 1%{?dist} +Release: 2%{?dist} License: BSD Group: Applications/Databases Source0: https://github.com/markokr/%{sname}/archive/%{version}.tar.gz @@ -58,6 +58,8 @@ rmdir lib %if %{pgmajorversion} != 92 sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' sql/pgq/triggers/stringutil.c %endif +sed -ie '/^pg83/s:shell test.*$:shell [ $( echo -e "$PGVER\\n8.3"|sort -gt. -k1 -k2|head -n1 ) = $PGVER ] \&\& echo false || echo true):' sql/txid/Makefile +sed -ie '/^pg82/s:shell test.*$:shell [ $( echo -e "$PGVER\\n8.2"|sort -gt. -k1 -k2|head -n1 ) = $PGVER ] \&\& echo false || echo true):' sql/txid/Makefile ./autogen.sh %configure --with-pgconfig=%{pginstdir}/bin/pg_config --with-asciidoc @@ -189,6 +191,9 @@ sed -ie '/^#include <parser\/keywords.h>/s:parser/keywords.h:common/keywords.h:' %{pginstdir}/share/contrib/pgq_triggers.sql %changelog +* Mon Dec 18 2017 Victor Yegorov <[email protected]> - 3.2.6-2 +- Fix sql/txid/Makefile for new versioning scheme + * Wed Sep 28 2016 Victor Yegorov <[email protected]> - 3.2.6-1 - Update to 3.2.6 ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2018-01-09 11:09 Victor Yegorov <[email protected]> parent: Victor Yegorov <[email protected]> 0 siblings, 1 reply; 8+ messages in thread From: Victor Yegorov @ 2018-01-09 11:09 UTC (permalink / raw) To: Devrim Gündüz <[email protected]>; +Cc: Christoph Berg <[email protected]>; pgsql-pkg-yum 2017-12-18 21:17 GMT+02:00 Victor Yegorov <[email protected]>: > 2017-12-15 18:35 GMT+02:00 Devrim Gündüz <[email protected]>: >> >> I have no idea whether this patch may break other parts of Skytools or >> not, so >> not sure. > > > I've made another change than, that fixes PG version detection in the > sql/txid/Makefile. > With this patch I got `skytools` build fine here. > Devrim, Do you think my 2nd patch is good to be merged? -- Victor Yegorov ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Skytools for 10 — RPM missing @ 2018-01-09 11:28 Devrim Gündüz <[email protected]> parent: Victor Yegorov <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: Devrim Gündüz @ 2018-01-09 11:28 UTC (permalink / raw) To: Victor Yegorov <[email protected]>; +Cc: Christoph Berg <[email protected]>; pgsql-pkg-yum Hi, On Tue, 2018-01-09 at 13:09 +0200, Victor Yegorov wrote: > Do you think my 2nd patch is good to be merged? Did you try to submit it to upstream for a new release? Regards, -- Devrim Gündüz EnterpriseDB: https://www.enterprisedb.com PostgreSQL Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2018-01-09 11:28 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2017-12-13 20:16 Skytools for 10 — RPM missing Victor Yegorov <[email protected]> 2017-12-13 21:17 ` Devrim Gündüz <[email protected]> 2017-12-14 09:58 ` Christoph Berg <[email protected]> 2017-12-15 13:17 ` Victor Yegorov <[email protected]> 2017-12-15 16:35 ` Devrim Gündüz <[email protected]> 2017-12-18 19:17 ` Victor Yegorov <[email protected]> 2018-01-09 11:09 ` Victor Yegorov <[email protected]> 2018-01-09 11:28 ` Devrim Gündüz <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox