Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aLjot-00081d-NS for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 20 Jan 2016 03:52:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aLjot-0001wx-0q for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 20 Jan 2016 03:52:31 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aLjor-0001wo-G0 for pgsql-pkg-yum@postgresql.org; Wed, 20 Jan 2016 03:52:29 +0000 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aLjoj-00084w-Az for pgsql-pkg-yum@postgresql.org; Wed, 20 Jan 2016 03:52:28 +0000 Received: by mail-lf0-x229.google.com with SMTP id m198so204198305lfm.0 for ; Tue, 19 Jan 2016 19:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j2cBtxovdURfc5fnp6OFp4ncLXwVHCNTyisCmBTvHPg=; b=XOK7NzOoQ06z6ZPfsXzbKa+fJOp/HwWk2tU61et14rJqUeNsZThW4FxGGN9eEwa/Hf kan4JIB2Zcm8jlaW8jpo52amrIEvchuqkmBWQ5pm1ci5iTPYJw5k7mMWpypjubohUvZX C37VNHXpt+61k7CjlXGcXCizy8H9+L/0JKkLb4X0Sh/UjYxGNDIuZ2DxQr4CWHA1em03 opmg+yEw+pOJ6KDitZLoAeGVT77ISY2r2Forf3snJudlZsUKkSvr3fc/Adglr0VdpfG2 GCSyxi4794mBClOgD6GmXpPW7D0kYHSwvVri+8BxvneSORwDeFvhqZqBtxXdMu9x7xpf 7gGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=j2cBtxovdURfc5fnp6OFp4ncLXwVHCNTyisCmBTvHPg=; b=LUGBzEIbq206t0VfaUoWBgUp1kQxnfyl9LBcXX265bKCLEIFdMyJ5UdZR8RbSJUYYV CoX9vgYV+hbc+92fTtTWiZBKcJw4/aX/WMc/hkIXV14uoSC6DdZm3kjtdcFy56K//sM4 JfSWzI3ZStB8vZKouu029rKrvOhvQWTubh4eRw8PKx6TvnJG6KI/2D8cV7CCJ8ZAGOGs BQOMVgV+QxG4OaovJBWrQm9M2Rb9FRQAKtDEycDMHgQp033gxDhg9vt6IjoNxOEdCBDq VQlYDw6lNYv2rf+D4x4/pRybswgj8tgC4p/8WiD2Yy47xNwusijnQyDD4DHJw4iD6UQM PRfw== X-Gm-Message-State: ALoCoQlJkKqv3GGWtVoeqMS8knHBxVjOhhH7JpXb7ecC+Tv9SNbC2eALSDhQRFNtdCrEkIXa80VAS8STi/7TbkPXs9lxbEFOxgAYH256YP7xkTiU3o6lCsE= MIME-Version: 1.0 X-Received: by 10.25.18.162 with SMTP id 34mr10908585lfs.52.1453261938251; Tue, 19 Jan 2016 19:52:18 -0800 (PST) Received: by 10.114.1.7 with HTTP; Tue, 19 Jan 2016 19:52:17 -0800 (PST) In-Reply-To: References: <1453239881.24314.362.camel@gunduz.org> Date: Wed, 20 Jan 2016 11:52:17 +0800 Message-ID: Subject: Re: New and unified 9.5 spec file is in git From: Craig Ringer To: =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Cc: pgsql-pkg-yum Content-Type: multipart/alternative; boundary=001a113fbf0e9876690529bbe9dc X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --001a113fbf0e9876690529bbe9dc Content-Type: text/plain; charset=UTF-8 On 20 January 2016 at 10:15, Craig Ringer wrote: > If anyone could take a look at it, it would be awesome. >> > > I'll look right now. > It built perfectly with mock on Fedora 21 for a F23 target. Brilliant! To make it clear that they're the same is it worth having a common/ directory at the same level as EL-5, F-23, etc and symlinking the specfile to the various subdirs from there, along with any identical patches etc? Here's the full build process I used: sudo yum -y install rpmdevtools mock git clone git://git.postgresql.org/git/pgrpms.git cd pgrpms/rpm/redhat/9.5/postgresql/F-23 spectool --get-files postgresql-9.5.spec mock -r fedora-23-x86_64 --buildsrpm --sources . --spec postgresql-9.5.spec cp /var/lib/mock/fedora-23-x86_64/result/postgresql95-9.5.0-2PGDG.fc23.src.rpm . mock -r fedora-23-x86_64 --rebuild postgresql95-9.5.0-2PGDG.fc23.src.rpm I'm really happy about this, since it means the build depends are now correct and it can be built without needing a dedicated build machine using nothing but mock. No need to manually set up dependencies anymore, set up a build box, etc. No need to juggle x86_64 and i386 either, you can run builds for *everything* from a single F23 box or VM or docker or whatever. If the same process is followed for other packages then it'll become possible to build the whole PGDG system with mockchain with no custom build machines, building anywhere that mock is available. No accidental undeclared build or runtime dependencies. Since you seem to be using Docker to prep build envs now it's less of an issue than when the build boxes are hand-maintained, but the great thing about mock is that it gets all the build depends info straight from the spec file. I also rebuilt the F23 package for F21 just by changing the -r argument to mock. Same for building it for i386 on an x86_64 host. The EL-5 package built happily under mock for -r epel-5-i386 too. I didn't test install it. Thanks so much. This is great and I really hope you got some use out of my prior work on it. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services --001a113fbf0e9876690529bbe9dc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 2= 0 January 2016 at 10:15, Craig Ringer <craig@2ndquadrant.com> wrote:
=C2=A0
If anyone could take a look at it, it would be awesome.
=

I'll look right now.

It built perfectly with moc= k on Fedora 21 for a F23 target. Brilliant!

To make it= clear that they're the same is it worth having a common/ directory at = the same level as EL-5, F-23, etc and symlinking the specfile to the variou= s subdirs from there, along with any identical patches etc?

<= /div>
Here's the full build process I used:

sudo yum -y install rpmdevtools mock
git clone=C2=A0git://git.postgresql.org/git/pgrpms.git
cd p= grpms/rpm/redhat/9.5/postgresql/F-23
sp= ectool --get-files postgresql-9.5.spec
mock= -r fedora-23-x86_64 --buildsrpm --sources . --spec postgresql-9.5.spec
cp /var/lib/mock/fedora-23-x86_64/result/postg= resql95-9.5.0-2PGDG.fc23.src.rpm .
mock= -r fedora-23-x86_64 =C2=A0--rebuild postgresql95-9.5.0-2PGDG.fc23.src.rpm<= /div>

I'm really happy about this, since = it means the build depends are now correct and it can be built without need= ing a dedicated build machine using nothing but mock. No need to manually s= et up dependencies anymore, set up a build box, etc. No need to juggle x86_= 64 and i386 either, you can run builds for *everything* from a single F23 b= ox or VM or docker or whatever.

<= div class=3D"gmail_extra">If the same process is followed for other package= s then it'll become possible to build the whole PGDG system with mockch= ain with no custom build machines, building anywhere that mock is available= . No accidental undeclared build or runtime dependencies.=C2=A0 Since you s= eem to be using Docker to prep build envs now it's less of an issue tha= n when the build boxes are hand-maintained, but the great thing about mock = is that it gets all the build depends info straight from the spec file.

I also re= built the F23 package for F21 just by changing the -r argument to mock. Sam= e for building it for i386 on an x86_64 host.

The EL-5 package built happily unde= r mock for -r epel-5-i386 too. I didn't test install it.

Thanks so much. This= is great and I really hope you got some use out of my prior work on it.

--
=C2=A0Craig Ringer=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 http://www.2ndQuadrant.com/
=C2=A0PostgreSQL Development, 24= x7 Support, Training & Services
--001a113fbf0e9876690529bbe9dc--