Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fprdU-0001qt-CI for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 15 Aug 2018 08:58:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fprdS-0001vX-Bq for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 15 Aug 2018 08:58:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fprdR-0001vQ-VO for pgsql-pkg-yum@lists.postgresql.org; Wed, 15 Aug 2018 08:58:34 +0000 Received: from mail-ua1-x941.google.com ([2607:f8b0:4864:20::941]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fprdO-0002YS-10 for pgsql-pkg-yum@postgresql.org; Wed, 15 Aug 2018 08:58:32 +0000 Received: by mail-ua1-x941.google.com with SMTP id o11-v6so529555uak.5 for ; Wed, 15 Aug 2018 01:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=iXYFgZJqdI1ZGuf5oMcP+5U4p6sP1vdmwPA7hmi3/C8=; b=VRS16XLo83LUMrptKU9WP6c14VkdWz1YXw4ojElw8fUfHRba2oMuWoS8tzvR2KL71T vXJVmdqr97s0G4ICCyIlMwn+HtOgoG9WR/lCtvz1aBUiF6LGtUGs31/X0uEcX49ObSSn O9yxJdWsX3RvwGmS1gr5SZCDBepkbI9NqrxxNeB6o4Uao+TaB/3GuQmA3BSE2Ehx9e/+ 8tt6OWu6rhf5Baf5C8yCaun+STK49RSa2F0J8KTpGx0721u9LH+He43un0RHEHxM3V8k ee/+48vgUhTJsemGskw+x7+duXt8mMfxSfxJ9S466ebl5pXn0tC3PRjGicBj3uEDoPSV AiEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iXYFgZJqdI1ZGuf5oMcP+5U4p6sP1vdmwPA7hmi3/C8=; b=XoNrETsvOggCQKxZtJBf8f/Z4tZixjo/BNPguaPZC6pVFimD9YJAVgxhPowy4NuTVX i0w/6UHDgVIYXLuT35Z3dRW1fwY9R+1pYrwGkWP99iDBy1slq5a2XEIZTgMEWLEtphsj Cxw/p2UDegx7HBmOGWAS+qFK6tOzI5IKIZu2xlwklIhonqhh8YFkyFbu3sKXiK9C/2jY AWGdSSt9RqtU6prhcM96/I8EX/WPa9CXnTyjPwiqJQlSJlkJt6q7DBYYpneZ73/6VGJw FnQLGnDsyRrn5RTLq+mATMTtb8DOdJ62hUN95anMYRVBv3zxNZAk/cA6qwkwGXY3l4yZ rzQw== X-Gm-Message-State: AOUpUlEbUWIuTpD19qV55NJoiiqKeyvAUCV+YidOF+2nRndFTVDUZqp0 jc9oelOxFh/g+AnlITreo+MamAjzGGbPxzBiRaJ7L7uM8nA= X-Google-Smtp-Source: AA+uWPwtjJy/T27J905XYECrKaqtu2j6mSTb51RaYJzDJYjxTmZmndOWYFdNcHV6lpqkxzg8kbg5YssCNCybzAJp0Q4= X-Received: by 2002:ab0:10cc:: with SMTP id x12-v6mr16488930uab.55.1534323508251; Wed, 15 Aug 2018 01:58:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:624a:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 01:58:27 -0700 (PDT) From: Craig Ringer Date: Wed, 15 Aug 2018 16:58:27 +0800 Message-ID: Subject: 9.4.19 devel packages pg_config.h broken To: pgsql-pkg-yum Content-Type: multipart/alternative; boundary="000000000000ae2f7e0573758782" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ae2f7e0573758782 Content-Type: text/plain; charset="UTF-8" Hi folks The 9.4.19 devel package appears to have a misplaced pg_config.h. Compare: $ rpm -qlp ~/Downloads/postgresql94-devel-9.4.19-1PGDG.f27.x86_64.rpm |grep 'pg_config.h' /usr/pgsql-9.4/include/postgresql-94-ecpg_config.h /usr/pgsql-9.4/include/postgresql-94-pg_config.h /usr/pgsql-9.4/include/server/postgresql-94-pg_config.h with $ rpm -qlp ~/Downloads/postgresql96-devel-9.6.10-1PGDG.f27.x86_64.rpm |grep 'pg_config.h' /usr/pgsql-9.6/include/ecpg_config.h /usr/pgsql-9.6/include/pg_config.h /usr/pgsql-9.6/include/server/pg_config.h Note we have postgresql-94-pg_config.h in 9.4, and pg_config.h in 9.6. I suspect this was an unintended change. I can't see where it came from in any recent commits, which is a bit surprising. There's Source5: %{sname}-%{pgmajorversion}-pg_config.h in the redhat master packages for postgresql, but that's fine/normal. Changes in 3a4b12670 on May 10 added unified Makefile for PostgreSQL 9.4, which seems to have changed Source5: pg_config.h to Source5: %{sname}-%{pgmajorversion}-pg_config.h and I'm guessing the problem got introduced there somehow. I suspect the issue is that the 9.4 spec rpm/redhat/9.4/postgresql/master/postgresql-9.4.spec has %{__install} -m 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/ (line 715) wheras the pg10 spec rpm/redhat/10/postgresql/master/postgresql-10.spec has %{__install} -m 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/pg_config.h Note the destination file name specified for pg10 but not 9.4. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services --000000000000ae2f7e0573758782 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi folks

The 9.4.19 devel package appea= rs to have a misplaced pg_config.h. Compare:

= $ rpm -qlp ~/Downloads/postgresql94-devel-9.4.19-1PGDG.f27.x86_64.rpm |grep= 'pg_config.h'
/usr/pgsql-9.4/include/postgresql-94-ecpg_= config.h
/usr/pgsql-9.4/include/postgresql-94-pg_config.h
/usr/pgsql-9.4/include/server/postgresql-94-pg_config.h
=
with

$ rpm -qlp ~/Down= loads/postgresql96-devel-9.6.10-1PGDG.f27.x86_64.rpm |grep 'pg_config.h= '
/usr/pgsql-9.6/include/ecpg_config.h
/usr/pgsql-9= .6/include/pg_config.h
/usr/pgsql-9.6/include/server/pg_config.h<= /div>

Note we have=C2=A0postgresql-94-pg_config.= h in 9.4, and=C2=A0pg_config.h in 9.6.

= I suspect this was an unintended change. I can&#= 39;t see where it came from in any recent commits, which is a bit surprisin= g.

There's

<= div>Source5:=C2=A0 =C2=A0 %{sname}-%{pgmajorversion}-pg_config.h
<= div>
in the redhat master packages for postgresql, but that&#= 39;s fine/normal. Changes in 3a4b12670=C2=A0on May 10 added unified Makefil= e for PostgreSQL 9.4, which seems to have changed

= Source5:=C2=A0 =C2=A0 %{sname}-%{pgmajorversion= }-pg_config.h

and I'm gu= essing the problem got introduced there somehow.

I suspect the issue is that the 9.4 spec=C2=A0rpm/redhat/9= .4/postgresql/master/postgresql-9.4.spec has

<= div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 %{__install} -m= 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/

(line 715)

wheras= the pg10 spec=C2=A0rpm/redhat/10/postgresql/master/postgresql-10.spec has<= /div>

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 %{__install}= -m 644 %{SOURCE5} %{buildroot}%{pgbaseinstdir}/include/pg_config.h

Note the destination file name specified for pg10 but not= 9.4.




--
=C2= =A0Craig Ringer=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 http://www.2ndQuadrant.com/
=C2=A0Po= stgreSQL Development, 24x7 Support, Training & Services
=
--000000000000ae2f7e0573758782--