MIME-Version: 1.0
In-Reply-To: <1500710382.2815.1.camel@gunduz.org>
References: <96c26493-91f1-801f-9590-89d090abf98c@2ndquadrant.com>
 <1500710382.2815.1.camel@gunduz.org>
From: =?UTF-8?B?TWFydMOtbiBNYXJxdcOpcw==?= <martin@2ndquadrant.com>
Date: Sat, 22 Jul 2017 07:20:36 -0300
Message-ID: 
 <CAPdiE1wSZsEgQNkYyabjFQc=2iquaf2_QFgo-8bXzUWEL7A1WQ@mail.gmail.com>
Subject: Re: patch bug in 9.6 spec
To: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>
Cc: pgsql-pkg-yum <pgsql-pkg-yum@postgresql.org>
Content-Type: multipart/alternative; boundary="001a113ec070313e090554e555d8"
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

--001a113ec070313e090554e555d8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Ok, I will check.

Thanks,

El 22 jul. 2017 4:59 AM, "Devrim G=C3=BCnd=C3=BCz" <devrim@gunduz.org> escr=
ibi=C3=B3:

>
> Hi Martin,
>
> On Thu, 2017-07-06 at 22:16 -0300, Mart=C3=ADn Marqu=C3=A9s wrote:
> > I was making a custom build with a patch for 9.6 and found this which
> > seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
> >
> > %patch6 -p1
> > %if 0%{?rhel} && 0%{?rhel} <=3D 5
> > %patch7 -p1
> > %endif
> >
> > Compilation passed because I'm using rhel7, but that patch doesn't exis=
t
> > in the spec file, so if someone would have tried to compile it on rhel5
> > it would have failed.
> >
> > I didn't do much digging on when it got there, but it seems it would be
> > good to remove it.
>
> I think you are using an older version of the spec file -- this is from
> 9.6.3-2
> changelog:
>
> - Remove nonexistent Patch7 reference
>
> I refactored the spec files recently, so please let me know if you see mo=
re
> issues.
>
> Regards,
> --
> Devrim G=C3=BCnd=C3=BCz
> EnterpriseDB: https://www.enterprisedb.com
> PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Enginee=
r
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>

--001a113ec070313e090554e555d8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Ok, I will check.=C2=A0<div dir=3D"auto"><br></div><div d=
ir=3D"auto">Thanks,</div></div><div class=3D"gmail_extra"><br><div class=3D=
"gmail_quote">El 22 jul. 2017 4:59 AM, &quot;Devrim G=C3=BCnd=C3=BCz&quot; =
&lt;<a href=3D"mailto:devrim@gunduz.org">devrim@gunduz.org</a>&gt; escribi=
=C3=B3:<br type=3D"attribution"><blockquote class=3D"gmail_quote" style=3D"=
margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Hi Martin,<br>
<br>
On Thu, 2017-07-06 at 22:16 -0300, Mart=C3=ADn Marqu=C3=A9s wrote:<br>
&gt; I was making a custom build with a patch for 9.6 and found this which<=
br>
&gt; seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package=
:<br>
&gt;<br>
&gt; %patch6 -p1<br>
&gt; %if 0%{?rhel} &amp;&amp; 0%{?rhel} &lt;=3D 5<br>
&gt; %patch7 -p1<br>
&gt; %endif<br>
&gt;<br>
&gt; Compilation passed because I&#39;m using rhel7, but that patch doesn&#=
39;t exist<br>
&gt; in the spec file, so if someone would have tried to compile it on rhel=
5<br>
&gt; it would have failed.<br>
&gt;<br>
&gt; I didn&#39;t do much digging on when it got there, but it seems it wou=
ld be<br>
&gt; good to remove it.<br>
<br>
I think you are using an older version of the spec file -- this is from 9.6=
.3-2<br>
changelog:<br>
<br>
- Remove nonexistent Patch7 reference<br>
<br>
I refactored the spec files recently, so please let me know if you see more=
<br>
issues.<br>
<br>
Regards,<br>
--<br>
Devrim G=C3=BCnd=C3=BCz<br>
EnterpriseDB: <a href=3D"https://www.enterprisedb.com" rel=3D"noreferrer" t=
arget=3D"_blank">https://www.enterprisedb.com</a><br>
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer<=
br>
Twitter: @DevrimGunduz , @DevrimGunduzTR<br>
</blockquote></div></div>

--001a113ec070313e090554e555d8--