Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: init script for pgpool
From: Jeff Frost <jeff@pgexperts.com>
In-Reply-To: <362161442625051@web30m.yandex.ru>
Date: Fri, 18 Sep 2015 18:27:38 -0700
Cc: "pgsql-pkg-yum@postgresql.org" <pgsql-pkg-yum@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <EF3E277A-9E82-443A-AACA-E87FA9D58812@pgexperts.com>
References: <306581442235608@web6m.yandex.ru>
 <F5B8EE67-19BD-4224-B71D-CD03E826CE61@pgexperts.com>
 <280191442580051@web12h.yandex.ru>
 <89FABBBA-D585-4AA9-889F-962595C2DE1A@pgexperts.com>
 <1964951442604225@web16j.yandex.ru>
 <FD559878-19B3-4E6C-B944-FC8069FBDE27@pgexperts.com>
 <1325321442612766@web4j.yandex.ru>
 <B0BA3096-C59D-405E-A9E3-C2BEA6BB7613@pgexperts.com>
 <236381442615195@web8j.yandex.ru>
 <B31AD711-3B3A-4D25-BCCF-5BF8426519A5@pgexperts.com>
 <362161442625051@web30m.yandex.ru>
To: Andrew N Golovkov <andor000@ya.ru>
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

Merged.

It=E2=80=99ll show up in the repo the next time we build packages.


> On Sep 18, 2015, at 6:10 PM, Andrew N Golovkov <andor000@ya.ru> wrote:
>=20
> Awesome! Thanks!
>=20
> 19.09.2015, 02:00, "Jeff Frost" <jeff@pgexperts.com>:
>> This should address all your concerns:
>>=20
>> http://git.postgresql.org/gitweb/?p=3Dpgrpms.git;a=3Dblob_plain;f=3Drpm/=
redhat/9.2/pgpool-II/EL-6/pgpool.init;hb=3Djf/pgpool_fixes_3
>>=20
>>>  On Sep 18, 2015, at 3:26 PM, Andrew N Golovkov <andor000@ya.ru> wrote:
>>>=20
>>>  git diff -b: https://bpaste.net/show/89b37acb8f0a
>>>=20
>>>  Removed `switch' action, because not supported at least from 3.3.3, wh=
ere init-script changed in upstream;
>>>=20
>>>  Every call stop/start/reload with correct calls and use variable `$PGP=
OOLUSER'
>>>  Removed unhandled arguments from `failure' and `success' function call=
s;
>>>  Cleanup useless commands and exit's.
>>>=20
>>>  Every line aligned with tabs;
>>>=20
>>>  Version in comment is 3.4 as proposed Devrim.
>>>=20
>>>  19.09.2015, 00:50, "Jeff Frost" <jeff@pgexperts.com>:
>>>>   Could you use diff -b so it doesn=E2=80=99t show lines with just whi=
tespace different?
>>>>=20
>>>>>    On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <andor000@ya.ru> wr=
ote:
>>>>>=20
>>>>>    And again.
>>>>>=20
>>>>>    https://bpaste.net/show/20ee48a0fc81
>>>>>=20
>>>>>    Diff with your script and my (with little cosmetic changes from pr=
evious version).
>>>>>=20
>>>>>    18.09.2015, 23:45, "Jeff Frost" <jeff@pgexperts.com>:
>>>>>>    http://git.postgresql.org/gitweb/?p=3Dpgrpms.git;a=3Dblob_plain;f=
=3Drpm/redhat/9.2/pgpool-II/EL-6/pgpool.init;hb=3Djf/pgpool_fixes_3
>>>>>>=20
>>>>>>>     On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <andor000@ya.ru=
> wrote:
>>>>>>>=20
>>>>>>>     You load /etc/sysconfig/pgpool file _before_ you set variables =
like PGPOOLUSER and other.
>>>>>>>     Also you set PGPOOLUSER but run commands with hardcoded `postgr=
es' user:
>>>>>>>>     $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> =
"$PGPOOLLOG" 2>&1 < /dev/null
>>>>>>>=20
>>>>>>>     Please, look at my script i'v posted today.
>>>>>>>=20
>>>>>>>     18.09.2015, 20:17, "Jeff Frost" <jeff@pgexperts.com>:
>>>>>>>>     Nice catch! I found a couple other things as well, so here=E2=
=80=99s an updated version:
>>>>>>>>=20
>>>>>>>>     http://git.postgresql.org/gitweb/?p=3Dpgrpms.git;a=3Dblob_plai=
n;f=3Drpm/redhat/9.2/pgpool-II/EL-6/pgpool.init;hb=3Djf/pgpool_fixes_3
>>>>>>>>=20
>>>>>>>>     It seems to work in my vagrant, so let me know if it works for=
 you and I=E2=80=99ll get it merged, then the next time we build, we=E2=80=
=99ll have it in the repo.
>>>>>>>>=20
>>>>>>>>>      On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <andor000@ya.=
ru> wrote:
>>>>>>>>>=20
>>>>>>>>>      You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>>>>=20
>>>>>>>>>      Check script in attach. I'm tested in my centos-6 and pgpool=
-II-92.<pgpool.init>
>>>>>>>>>      --
>>>>>>>>>      Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresq=
l.org)
>>>>>>>>>      To make changes to your subscription:
>>>>>>>>>      http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>>>>=20
>>>>>>>>     ---
>>>>>>>>     Jeff Frost <jeff@pgexperts.com>
>>>>>>>>     CTO, PostgreSQL Experts, Inc.
>>>>>>>>     Phone: 1-888-PG-EXPRT x506
>>>>>>>>     FAX: 415-762-5122
>>>>>>>>     http://www.pgexperts.com/
>>>>>>=20
>>>>>>    ---
>>>>>>    Jeff Frost <jeff@pgexperts.com>
>>>>>>    CTO, PostgreSQL Experts, Inc.
>>>>>>    Phone: 1-888-PG-EXPRT x506
>>>>>>    FAX: 415-762-5122
>>>>>>    http://www.pgexperts.com/
>>>>=20
>>>>   ---
>>>>   Jeff Frost <jeff@pgexperts.com>
>>>>   CTO, PostgreSQL Experts, Inc.
>>>>   Phone: 1-888-PG-EXPRT x506
>>>>   FAX: 415-762-5122
>>>>   http://www.pgexperts.com/
>>=20
>> ---
>> Jeff Frost <jeff@pgexperts.com>
>> CTO, PostgreSQL Experts, Inc.
>> Phone: 1-888-PG-EXPRT x506
>> FAX: 415-762-5122
>> http://www.pgexperts.com/

---
Jeff Frost <jeff@pgexperts.com>
CTO, PostgreSQL Experts, Inc.
Phone: 1-888-PG-EXPRT x506
FAX: 415-762-5122
http://www.pgexperts.com/=20


--=20
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum