Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOiXY-0002wS-R7 for pgsql-pkg-yum@arkaria.postgresql.org; Tue, 23 Mar 2021 15:01:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lOiXX-0000F8-P2 for pgsql-pkg-yum@arkaria.postgresql.org; Tue, 23 Mar 2021 15:01:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOfgo-0000lc-Vr for pgsql-pkg-yum@lists.postgresql.org; Tue, 23 Mar 2021 11:59:14 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOfgm-0002Bh-Gn for pgsql-pkg-yum@postgresql.org; Tue, 23 Mar 2021 11:59:14 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1478:7c00:76e5:bff:fef3:7e00]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 4F4VJt2PB0z3Dwk; Tue, 23 Mar 2021 12:59:10 +0100 (CET) Date: Tue, 23 Mar 2021 12:59:09 +0100 From: Christoph Berg To: Justin Pryzby Cc: Stephen Frost , Devrim =?iso-8859-1?B?R/xuZPx6?= , pgsql-pkg-yum@postgresql.org Subject: Re: please build packages --with-lz4 Message-ID: Mail-Followup-To: Christoph Berg , Justin Pryzby , Stephen Frost , Devrim =?iso-8859-1?B?R/xuZPx6?= , pgsql-pkg-yum@postgresql.org References: <20210322020359.GF4203@telsasoft.com> <20210322144507.GV20766@tamriel.snowman.net> <20210322152034.GM4203@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210322152034.GM4203@telsasoft.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Re: Justin Pryzby > > I have to wonder why we aren't just automatically checking if lz4 is > > available and enabling it when it is... > > I assume you mean at compile time, regarding autoconf macros ? > > This probably doesn't apply to PGDG, but as I recall at least within debian, > there's a preference to build either --with-... or --without-.., so that a > library which happens to be installed doesn't create a package with an > unintentional dependency, or a library which is not installed or something > broken/incompatible doesn't result in a package without the intended > dependency. There is some value in making explicit statements in configure flags, but if the package declares "Build-Depends: liblz4-dev" and then configure picks that up automatically, there is not that much room for unwanted surprises. If we chose to deliberately go without lz4 support I'd in fact put a --without-lz4 into the list of options. The deeper question here is I guess, if lz4 is better than pglz, and besides why isn't --with-lz4 the default, why isn't it the default for all columns but needs some obsure GUC set? Christoph