Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 68D43B5DBE4 for ; Wed, 13 Jul 2011 23:08:30 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 22374-02; Thu, 14 Jul 2011 02:08:24 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-iy0-f174.google.com (mail-iy0-f174.google.com [209.85.210.174]) by mail.postgresql.org (Postfix) with ESMTP id 19A78B5DBE1; Wed, 13 Jul 2011 23:08:23 -0300 (ADT) Received: by iyb12 with SMTP id 12so6076788iyb.19 for ; Wed, 13 Jul 2011 19:08:24 -0700 (PDT) Received: by 10.43.43.200 with SMTP id ud8mr1990659icb.434.1310609302162; Wed, 13 Jul 2011 19:08:22 -0700 (PDT) Received: from [192.168.1.100] (c-69-181-249-16.hsd1.ca.comcast.net [69.181.249.16]) by mx.google.com with ESMTPS id my4sm9239190ibb.54.2011.07.13.19.08.20 (version=SSLv3 cipher=OTHER); Wed, 13 Jul 2011 19:08:21 -0700 (PDT) Subject: Re: [RRR] Three patches which desperately need reviewers From: Jeff Davis To: Florian Pflug Cc: Josh Berkus , postgres hackers , pgsql-rrreviewers@postgresql.org In-Reply-To: <731C9ABF-5B67-487A-B73B-97C37CA7CF0F@phlo.org> References: <4E1E3B7E.5020605@agliodbs.com> <731C9ABF-5B67-487A-B73B-97C37CA7CF0F@phlo.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 13 Jul 2011 19:08:19 -0700 Message-ID: <1310609299.31101.4.camel@jdavis> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201107/710 X-Sequence-Number: 191809 On Thu, 2011-07-14 at 02:54 +0200, Florian Pflug wrote: > On Jul14, 2011, at 02:42 , Josh Berkus wrote: > > lazy vxid locks > > https://commitfest.postgresql.org/action/patch_view?id=585 > > I can try to review that. It does seems to depend on > the fastlock patch though, and that patch seems to be > somewhat of a moving target. I'm thus not sure what the > most reasonable approach is here. I could wait for the > fastlock patch to be applied, but since the commitfest > is drawing to a close that might not be the best course > of action. How is such a situation handled usually? Moving target? Hopefully not. I marked it "ready for committer" already. I did give some feedback, but it's nothing that would get in the way of reviewing the VXID patch. So please do take a look at the VXID patch. Just apply it over the last version of the fastlock patch. I also plan to take a look, but the earliest will be tomorrow. Regards, Jeff Davis