Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 5C9A71337B3E for ; Sun, 16 Jan 2011 15:31:08 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 94759-09; Sun, 16 Jan 2011 19:31:01 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from marajade.localdomain (vcs5.camavision.com [63.228.164.252]) by mail.postgresql.org (Postfix) with ESMTP id D3B8413364DE; Sun, 16 Jan 2011 15:31:00 -0400 (AST) Received: from [192.168.1.116] (173-20-253-9.client.mchsi.com [173.20.253.9]) (Authenticated sender: andy) by marajade.localdomain (Postfix) with ESMTPA id 06E6941F67; Sun, 16 Jan 2011 13:30:59 -0600 (CST) Message-ID: <4D334772.9070709@squeakycode.net> Date: Sun, 16 Jan 2011 13:30:58 -0600 From: Andy Colson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Robert Haas CC: pgsql-hackers@postgresql.org, pgsql-rrreviewers@postgresql.org Subject: Re: [HACKERS] reviewers needed! References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-10 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201101/8 X-Sequence-Number: 383 I reviewed a couple patched, and I added my review to the commitfest page. If I find a problem, its obvious I should mark the patch as "returned with feedback". But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I leave it alone? Mark it as "ready for committer"? I marked my two reviews as ready for committer, but I feel like I've overstepped my bounds. -Andy