Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 258061337C2B for ; Sun, 16 Jan 2011 17:14:38 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 79618-01-9 for ; Sun, 16 Jan 2011 21:14:31 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from cpoproxy2-pub.bluehost.com (cpoproxy2-pub.bluehost.com [67.222.39.38]) by mail.postgresql.org (Postfix) with SMTP id 9086D1337BDB for ; Sun, 16 Jan 2011 17:13:38 -0400 (AST) Received: (qmail 9499 invoked by uid 0); 16 Jan 2011 21:13:37 -0000 Received: from unknown (HELO host159.hostmonster.com) (74.220.207.159) by cpoproxy2.bluehost.com with SMTP; 16 Jan 2011 21:13:36 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=timbira.com; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Identified-User; b=QrnW51KL2zw0Qk5YENfxjIPov5KMVy6r7crX1B/dZTROYRfa0qTfSn6+2UOJ2CQ9cJZzDUf3W93UZhjymXpIQNf5SKnrpwPZoo2gtd5yNTGaoZklY/UklTgRfc4qxcZF; Received: from [189.72.247.144] (helo=[10.0.0.10]) by host159.hostmonster.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1PeZup-0001fT-EW; Sun, 16 Jan 2011 14:13:36 -0700 Message-ID: <4D335F7A.7010906@timbira.com> Date: Sun, 16 Jan 2011 18:13:30 -0300 From: Euler Taveira de Oliveira User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101227 Icedove/3.0.11 MIME-Version: 1.0 To: Andy Colson CC: Robert Haas , pgsql-hackers@postgresql.org, pgsql-rrreviewers@postgresql.org Subject: Re: [HACKERS] reviewers needed! References: <4D334772.9070709@squeakycode.net> In-Reply-To: <4D334772.9070709@squeakycode.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Identified-User: {1651:host159.hostmonster.com:timbirac:timbira.com} {sentby:smtp auth 189.72.247.144 authed with euler@timbira.com} X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.89 tagged_above=-10 required=5 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, T_FRT_PROFILE2=0.01 X-Spam-Level: X-Archive-Number: 201101/9 X-Sequence-Number: 384 Em 16-01-2011 16:30, Andy Colson escreveu: > I reviewed a couple patched, and I added my review to the commitfest page. > > If I find a problem, its obvious I should mark the patch as "returned > with feedback". > > But what if I'm happy with it? I'm not a hacker so cannot do C code > review, should I leave it alone? Mark it as "ready for committer"? > Did you take a look at [1]? If your patch involves C code and you're not C proficient then there must be another reviewer to give his/her opinion (of course, the other person could be the committer). I wouldn't mark it "ready for committer" instead leave it as is ("needs review"); just be sure to add your comments in the commitfest app. [1] http://wiki.postgresql.org/wiki/RRReviewers -- Euler Taveira de Oliveira http://www.timbira.com/