Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 741211D983B7 for ; Mon, 14 Nov 2011 22:02:38 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 39059-07 for ; Tue, 15 Nov 2011 02:02:32 +0000 (UTC) X-Greylist: delayed 00:09:22.199975 by SQLgrey-1.8.0-rc2 Received: from magus.postgresql.org (magus.postgresql.org [87.238.57.229]) by mail.postgresql.org (Postfix) with ESMTP id 7FB271D983B6 for ; Mon, 14 Nov 2011 22:02:32 -0400 (AST) Received: from moutng.kundenserver.de ([212.227.17.8]) by magus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1RQ8Cz-0002Jf-Se for pgsql-rrreviewers@postgresql.org; Tue, 15 Nov 2011 01:53:10 +0000 Received: from [192.168.1.6] (mail.highperformancepostgresql.com [71.179.240.8]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0LrqDW-1QlokY41bK-013t3n; Tue, 15 Nov 2011 02:52:57 +0100 Message-ID: <4EC1C5F8.2030109@2ndQuadrant.com> Date: Mon, 14 Nov 2011 20:52:56 -0500 From: Greg Smith User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20111110 Icedove/3.0.11 MIME-Version: 1.0 To: pgsql-rrreviewers@postgresql.org Subject: Re: Sign me up References: <76B1DD74-24D8-4F79-8720-0097701AC2E1@inomial.com> In-Reply-To: <76B1DD74-24D8-4F79-8720-0097701AC2E1@inomial.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:y+5PxYHp6rUvISrJ8ZJkpKhjs/ME+39db5ufN3kN7ZK F3dVAIL5Qf8YLGzseFu1f5YjMWfgAr//dYdoN6/XnnyXHS2QJ7 V/esj4E6Zi8veCXG2mSXe+F/Rc2YASnSUCK6RwcWV8s2BU8VyD 0w5VdK5SMhazZ120UB2yOxTPpHXvywnz7e3EOWHN5Yxi4uV0k1 VH3bCkHUeSTLYIrCUu13G01rWqYJdXRqaHFEYGFKmZjGylBg1L I9HbynCFSvzmuvwzCopBpr32JI21PKRqR4KPg9sk1b+SkpkzLd aCQ7Zw/8QXUnrHuU05vv001Q18Wdl5r4zsIx1DDAMaclgSRd8y gY4O0tuJL5+K6bOOld/c= X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-10 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201111/2 X-Sequence-Number: 462 On 11/14/2011 04:17 PM, Royce Ausburn wrote: > Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;) I'm not strong in C either, but I'll nut it out. > How about "Include detailed information about a row failing a CHECK constraint into the error message"? There's not a lot of code there, the main review work is preparing a test case that demonstrates the code does its job. (One really should have been included with the patch, but this condition isn't difficult to recreate) If that sounds reasonable, just edit the patch and add yourself there. I see you've already created your own entry there, so you know how that works. -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us