Received: from mailsys01.intnet.net (antares.intnet.net [198.252.32.143]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f5FMh2a90170 for ; Fri, 15 Jun 2001 18:43:02 -0400 (EDT) (envelope-from joseph.conway@home.com) Received: from [206.19.64.3] (HELO jecw2k1) by mailsys01.intnet.net (CommuniGate Pro SMTP 3.3.2) with SMTP id 9863109; Fri, 15 Jun 2001 18:41:58 -0400 Message-ID: <005101c0f5ec$83f56b80$d7d310ac@jecw2k1> From: "Joe Conway" To: "Larry Rosenman" , "PostgreSQL SQL List" References: <20010615170950.A3303@lerami.lerctr.org> Subject: Re: Why doesn't this pgsql function compile? Date: Fri, 15 Jun 2001 15:42:53 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4522.1200 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 X-Archive-Number: 200106/223 X-Sequence-Number: 3481 > When this PLpgsql function gets called on the trigger > it fails compilation on the last line. > > What am I doing wrong? > > > IF TG_OP = ''INSERT'' > THEN add_ip_route(host(network(NEW.netblock)), > host(netmask(NEW.netblock)), > get_router_ethernet(NEW.router), > get_router_nexthop(NEW.router), > get_router_nexthop_user(NEW.router), > get_router_nexthop_password(NEW.router), > get_router_nexthop_enpass(NEW,router)); > return NEW; > END IF; Don't you need a "PERFORM" between the "THEN" and "add_ip_route(. . ." above (and similar places below)? -- Joe > IF TG_OP = ''DELETE'' > THEN del_ip_route(host(network(OLD.netblock)), > host(netmask(OLD.netblock)), > get_router_ethernet(OLD.router), > get_router_nexthop(OLD.router), > get_router_nexthop_user(OLD.router), > get_router_nexthop_password(OLD.router), > get_router_nexthop_enpass(OLD,router)); > return OLD; > -- TG_OP must be UPDATE to get here.... > IF OLD.router NOTNULL and get_router_nexthop(OLD.router) NOTNULL > AND NEW.router NOTNULL and OLD.router != NEW.router > THEN del_ip_route(host(network(OLD.netblock)), > host(netmask(OLD.netblock)), > get_router_ethernet(OLD.router), > get_router_nexthop(OLD.router), > get_router_nexthop_user(OLD.router), > get_router_nexthop_password(OLD.router), > get_router_nexthop_enpass(OLD,router)); > END IF; > IF NEW.router NOTNULL and get_router_nexthop(NEW.router) NOTNULL > THEN add_ip_route(host(network(NEW.netblock)), > host(netmask(NEW.netblock)), > get_router_ethernet(NEW.router), > get_router_nexthop(NEW.router), > get_router_nexthop_user(NEW.router), > get_router_nexthop_password(NEW.router), > get_router_nexthop_enpass(NEW,router)); > END IF; > return NEW; > END;' > LANGUAGE 'plpgsql';