Received: from anchor-post-33.mail.demon.net (anchor-post-33.mail.demon.net [194.217.242.91]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f6J9XUa04140 for ; Thu, 19 Jul 2001 05:33:30 -0400 (EDT) (envelope-from dev@archonet.com) Received: from mwynhau.demon.co.uk ([193.237.186.96] helo=mainbox.archonet.com) by anchor-post-33.mail.demon.net with esmtp (Exim 2.12 #1) id 15NABP-0001Ga-0X; Thu, 19 Jul 2001 10:33:25 +0100 Received: from client (client.archonet.com [192.168.1.16]) by mainbox.archonet.com (Postfix) with SMTP id 7D0C41370F; Thu, 19 Jul 2001 10:04:37 +0100 (BST) Message-ID: <007001c11031$d339b160$1001a8c0@archonet.com> From: "Richard Huxton" To: "Tom Lane" Cc: "Gary Stainburn" , "pgsql-sql" , "Josh Berkus" References: <01071815102309.11978@gary.ringways.co.uk> <0107181624100B.11978@gary.ringways.co.uk> <002301c10fa6$1f176820$1001a8c0@archonet.com> <12745.995488498@sss.pgh.pa.us> Subject: Re: pl/pgsql - code review + question Date: Thu, 19 Jul 2001 10:04:30 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Archive-Number: 200107/256 X-Sequence-Number: 4053 From: "Tom Lane" > "Richard Huxton" writes: > > Don't know why the parser for RAISE doesn't like string concat. > > Laziness ;-). Someone should fix plpgsql so that RAISE does take > expressions, not just literals and simple variables. It probably > wouldn't be a big change, but I've no time to look at it myself; > any volunteers out there? False Laziness perhaps (spot my Perl background) OK - stick me down for having a look at it. Had a quick peek and I think it's within my abilities. Give me a couple of weeks, because I haven't looked at a YACC file since my university days (gram.y is YACC isn't it?) I'll read up the rules for submitting patches and get something workable back by August 3rd. Josh - if I try and do OFFSET at the same time (presumably it's the same change) do you fancy acting as a sanity test site? - Richard Huxton