X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by postgresql.org (Postfix) with ESMTP id EA77D9DCBD5 for ; Wed, 1 Mar 2006 19:21:23 -0400 (AST) Received: from postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 31604-01 for ; Wed, 1 Mar 2006 19:21:26 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id C057D9DC821 for ; Wed, 1 Mar 2006 19:21:21 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id k21NKqcH016880; Wed, 1 Mar 2006 18:20:52 -0500 (EST) To: Mark Dilger cc: Bruce Momjian , pgsql-hackers@postgresql.org Subject: Re: [SQL] Interval subtracting In-reply-to: <4406292A.1050403@markdilger.com> References: <16569.1141253147@sss.pgh.pa.us> <200603012302.k21N2Hm04879@candle.pha.pa.us> <4406292A.1050403@markdilger.com> Comments: In-reply-to Mark Dilger message dated "Wed, 01 Mar 2006 15:07:22 -0800" Date: Wed, 01 Mar 2006 18:20:52 -0500 Message-ID: <16879.1141255252@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, score=0.111 required=5 tests=[AWL=0.111] X-Spam-Score: 0.111 X-Spam-Level: X-Archive-Number: 200603/83 X-Sequence-Number: 80481 Mark Dilger writes: > Bruce Momjian wrote: >> If we do that, we should just call it justify_interval(). I am thinking >> this is the direction to go, and for people who want more control they >> use the justify_hours and justify_days, and those are left unchanged. > I agree. Let's leave the existing functions alone. No, we still need to fix them to not leave a large negative value in place for seconds or days (respectively). The current coding is unquestionably inadequate. regards, tom lane