Received: from sss.pgh.pa.us ([192.204.191.242]) by postgresql.org (8.11.3/8.11.4) with ESMTP id g0EM2FV18642 for ; Mon, 14 Jan 2002 17:02:15 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.4/8.11.4) with ESMTP id g0EM1tg19530; Mon, 14 Jan 2002 17:01:55 -0500 (EST) To: tjennette@thomasnelson.com (Trace) cc: pgsql-sql@postgresql.org Subject: Re: SQL Joins In-reply-to: <56893385.0201081316.25272d8c@posting.google.com> References: <56893385.0201081316.25272d8c@posting.google.com> Comments: In-reply-to tjennette@thomasnelson.com (Trace) message dated "08 Jan 2002 13:16:28 -0800" Date: Mon, 14 Jan 2002 17:01:55 -0500 Message-ID: <19527.1011045715@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200201/150 X-Sequence-Number: 6236 tjennette@thomasnelson.com (Trace) writes: > Can someone please tell me what this previously-written SQL is doing? > I don't understand how it is structured. Apparently whoever wrote this doesn't believe in parentheses. I'd think it a lot more readable with parentheses and appropriate indentation, viz: FROM ( (eStoreManager.estore_dept_prod LEFT OUTER JOIN eStoreManager.estore_product ON eStoreManager.estore_dept_prod.sku = eStoreManager.estore_product.sku) RIGHT OUTER JOIN (eStoreManager.tblCProductClass LEFT OUTER JOIN eStoreManager.tblCProductClassProduct ON eStoreManager.tblCProductClass.ProductClassID = eStoreManager.tblCProductClassProduct.ProductClassID) ON eStoreManager.estore_product.sku = eStoreManager.tblCProductClassProduct.sku) FULL OUTER JOIN (eStoreManager.tblCProductClassCreator INNER JOIN eStoreManager.tblCCreator ON eStoreManager.tblCProductClassCreator.CreatorID = eStoreManager.tblCCreator.CreatorID) ON eStoreManager.tblCProductClass.ProductClassID = eStoreManager.tblCProductClassCreator.ProductClassID BTW, since Postgres doesn't have schemas you'd need to lose the "eStoreManager." prefixes, which aren't doing anything for readability here either: FROM ( (estore_dept_prod LEFT OUTER JOIN estore_product ON estore_dept_prod.sku = estore_product.sku) RIGHT OUTER JOIN (tblCProductClass LEFT OUTER JOIN tblCProductClassProduct ON tblCProductClass.ProductClassID = tblCProductClassProduct.ProductClassID) ON estore_product.sku = tblCProductClassProduct.sku) FULL OUTER JOIN (tblCProductClassCreator INNER JOIN tblCCreator ON tblCProductClassCreator.CreatorID = tblCCreator.CreatorID) ON tblCProductClass.ProductClassID = tblCProductClassCreator.ProductClassID Does that help any? If you're wondering how I knew where to put the parentheses, it's because there's no place else they could go and still have a syntactically valid statement. So I suppose the author felt they were unnecessary. But I think it's more readable with 'em. regards, tom lane