To: Ralph Smith <rsmith@10kinfo.com>
cc: pgsql-sql@postgresql.org
Subject: Re: I'm stuck - I just can't get this small FUNCT to run! 
In-reply-to: <4CD1F792.6040907@10kinfo.com> 
References: <4CD1F792.6040907@10kinfo.com>
Comments: In-reply-to Ralph Smith <rsmith@10kinfo.com>
	message dated "Wed, 03 Nov 2010 17:00:18 -0700"
Date: Wed, 03 Nov 2010 23:50:08 -0400
Message-ID: <19968.1288842608@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Ralph Smith <rsmith@10kinfo.com> writes:
> I'm also stuck on 7.4 for at least a few more months, but that's not 
> part of the problem.

... well, actually, it is; because newer versions give considerably more
helpful syntax error messages.  I tried plugging this function into
a current version, and got

syntax error at or near "daRec"
LINE 34:     FOR daRec IN SELECT * FROM temp_salesimport WHERE offer_...
                 ^

which was at least close enough to the problem (the missing semi on the
previous line) to be of some use, unlike the error pointing at line 92.
Similarly, after fixing the first missing semi I got

ERROR:  syntax error at or near "select"
LINE 38:       select into vBusOwnerID businessownerid from business ...
               ^

which is just after the other one.

If you aren't in a position to move your production DB yet, you might
at least consider using a newer version for development.  That has its
own hazards of course, like accidentally using features that don't exist
in 7.4, but it could save you a lot of time in cases like this.

			regards, tom lane