Received: from candle.pha.pa.us (maillist@s5-03.ppp.op.net [209.152.195.67]) by hub.org (8.9.3/8.9.3) with ESMTP id NAA72539 for ; Fri, 9 Jul 1999 13:00:02 -0400 (EDT) (envelope-from maillist@candle.pha.pa.us) Received: (from maillist@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id MAA01689; Fri, 9 Jul 1999 12:56:57 -0400 (EDT) From: Bruce Momjian Message-Id: <199907091656.MAA01689@candle.pha.pa.us> Subject: Re: [SQL] RewriteDefine.c : Rule size In-Reply-To: <2314.931530245@sss.pgh.pa.us> from Tom Lane at "Jul 9, 1999 10:24:05 am" To: Tom Lane Date: Fri, 9 Jul 1999 12:56:57 -0400 (EDT) CC: Jim Rowan , Jan Wieck , Olivier Ertz , pgsql-sql@postgreSQL.org X-Mailer: ELM [version 2.4ME+ PL56 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit > There is a poorly-documented restriction that BLCKSZ can't exceed 32K > (IIRC, this is because block offsets are stored in signed shorts somewhere). > Probably would be a good idea to mention this in the comments in > config.h.in. > > For the long run it would be nice to remove the restriction. I have no > idea whether that would be easy or hard. Ideally we could do something > like > > #if BLCKSZ > 32767 > typedef int BlockOffset; > #else > typedef short BlockOffset; > #endif > > but finding all the places that need to use the typedef might be a pain. Added comment to config.h.in, and TODO item: * Allow BLCKSZ <= 64k, not <= 32k -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026