Received: from frithjof.reiner (qmailr@c09.dialin.tuwien.ac.at [192.35.243.19]) by hub.org (8.9.3/8.9.3) with SMTP id QAA52303 for ; Tue, 12 Oct 1999 16:43:20 -0400 (EDT) (envelope-from areiner@tph.tuwien.ac.at) Received: (qmail 21451 invoked by uid 500); 12 Oct 1999 12:22:40 -0000 From: "Albert REINER" Date: Tue, 12 Oct 1999 14:22:39 +0200 To: pgsql-sql@postgreSQL.org Subject: Re: [SQL] security: escaping user-supplied data Message-ID: <19991012142239.A16678@frithjof> Mail-Followup-To: pgsql-sql@postgreSQL.org References: <38028148.8066E930@uhlenkott.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.6i In-Reply-To: ; from Herouth Maoz on Tue, Oct 12, 1999 at 11:53:44AM +0200 On Tue, Oct 12, 1999 at 11:53:44AM +0200, Herouth Maoz wrote: > At 02:31 +0200 on 12/10/1999, Jason Uhlenkott wrote: > > > > The statements I generate are usually of the form: > > INSERT INTO foo (bar, bas) VALUES ('abc', 'def'); > > but the 'abc' and 'def' come from an untrusted source, so if they supply > > a string like "def'); delete from foo; '" they can make me do this: > > INSERT INTO foo (bar, bas) VALUES ('abc', 'def'); delete from foo; ''); > > > > What do I need to do to prevent this? My current plan is to prepend a > > backslash to every single-quote, backslash, and semicolon in the > > untrusted string. Are there any other special characters I should watch > > out for? Is it possible to do something evil despite your special > > characters being prepended with a backslash? > > I don't see why you would want to escape a semicolon. If you escape single > quotes and backslashes, the above situation won't happen - the string won't > be finished until the first unescaped quote - yours - is encountered. > Semicolons are not special in strings. > > Herouth I once posted a similar question to the pgsql-novice mailing list. There, David Rugge (1 Aug 1999) told me to escape ', ", and %, even though I am not quite sure why you have to escape " and %. But now that I think of it: you also need to escape \, of course, or backslashes will either get lost or, even worse, may escape the closing quote (think of $def="\"). Thus, using Perl and Pg, you would do: use Pg; $conn = ...; $abc="abc"; $def="def"; $conn->exec("INSERT INTO foo (bar, bas) VALUES ('" . &stdstr($abc) . "', '" . &stdstr($def) . "')"; sub stdstr { local $or = $_[0]; $or =~ s /\'/\\\'/g; $or =~ s /\"/\\\"/g; $or =~ s /%/\\%/g; $or =~ s /\\/\\\\/g; return $or; } Hope that helps, Albert. -- --------------------------------------------------------------------------- Post an / Mail to / Skribu al: Albert Reiner ---------------------------------------------------------------------------