Received: from as.tksoft.com (gyw.com [209.55.67.177] (may be forged)) by hub.org (8.9.3/8.9.3) with ESMTP id QAA96325 for ; Wed, 13 Oct 1999 16:56:15 -0400 (EDT) (envelope-from tjk@tksoft.com) Received: (from tjk@tksoft.com) by uno.tksoft.com (8.8.8/8.8.8) id NAA04976; Wed, 13 Oct 1999 13:54:32 -0700 From: "tjk@tksoft.com" Message-Id: <199910132054.NAA04976@uno.tksoft.com> Subject: Re: [SQL] security: escaping user-supplied data To: herouth@oumail.openu.ac.il (Herouth Maoz) Date: Wed, 13 Oct 1999 13:54:32 -0700 (PDT) Cc: jpu31@uhlenkott.net, pgsql-sql@postgreSQL.org In-Reply-To: from "Herouth Maoz" at Oct 12, 99 11:53:44 am Content-Type: text Here's a function in perl which should work for cleaning a string which is sent in a query: # The checks for already backslashed apostrophies and backslashes # prevent tricks with these, and also allow us to run clean_text() # several times. sub clean_text { my $text = shift; return "" if (! defined $text || ! length($text)); # First change backslashed backslashes back to single backslashes. $text =~ s/\\\\/\\/g; # Find backslash single quote combinations and convert them to single quotes. # while... is theoretically not necessary. It's there just as an assurance. while ($text =~ /\\\'/) { $text =~ s/\\\'/'/g; } # Now there should be no single quotes preceded by backslashes left. # Then find all backslashes and convert them to doubles. $text =~ s/\\/\\\\/g; # Now all characters preceded by a backslash should be in their # original state, while all backslashed single quotes are # just single quotes. # Find all single quotes and backslash them. # (Note: There are no single quotes preceded by a backslash, so # it is not possible to have a backslash which would hide a # backslash preceding a single quote.) $text =~ s/\'/\\'/g; return $text; } The function could be more efficient if you made $text a reference. If you know how to use references in Perl, then the conversion is easy. Just drop the "return" from the end and change all references to $text with $$text. You should also add a check such as "! defined $text || ! ref $text ||" to the second line's if statement. If you find a way to exploit this, I would like to know. Troy > > At 02:31 +0200 on 12/10/1999, Jason Uhlenkott wrote: > > > > The statements I generate are usually of the form: > > INSERT INTO foo (bar, bas) VALUES ('abc', 'def'); > > but the 'abc' and 'def' come from an untrusted source, so if they supply > > a string like "def'); delete from foo; '" they can make me do this: > > INSERT INTO foo (bar, bas) VALUES ('abc', 'def'); delete from foo; ''); > > > > What do I need to do to prevent this? My current plan is to prepend a > > backslash to every single-quote, backslash, and semicolon in the > > untrusted string. Are there any other special characters I should watch > > out for? Is it possible to do something evil despite your special > > characters being prepended with a backslash? > > I don't see why you would want to escape a semicolon. If you escape single > quotes and backslashes, the above situation won't happen - the string won't > be finished until the first unescaped quote - yours - is encountered. > Semicolons are not special in strings. > > Herouth > > -- > Herouth Maoz, Internet developer. > Open University of Israel - Telem project > http://telem.openu.ac.il/~herutma > > > > ************ > >