Received: from danbo.digsys.bg (root@danbo.digsys.bg [192.92.129.10]) by hub.org (8.9.3/8.9.3) with ESMTP id GAA00808 for ; Tue, 9 Nov 1999 06:15:44 -0500 (EST) (envelope-from genov@lorna.digsys.bg) Received: from lorna.digsys.bg (root@lorna.digsys.bg [193.68.6.15]) by danbo.digsys.bg (8.9.0/8.9.0) with ESMTP id NAA26909; Tue, 9 Nov 1999 13:15:39 +0200 (EET) Received: from lorna.digsys.bg (genov@localhost.digsys.bg [127.0.0.1]) by lorna.digsys.bg (8.9.0/8.9.0) with ESMTP id NAA11001; Tue, 9 Nov 1999 13:15:37 +0200 (EET) Message-Id: <199911091115.NAA11001@lorna.digsys.bg> X-Mailer: exmh version 2.0.2 2/24/98 To: "Hiroshi Inoue" , pgsql-sql@postgresql.org Subject: Re: [SQL] Move forward all (Was Re: How to get last 10 rows in a table on a large database?) In-reply-to: Your message of "Tue, 09 Nov 1999 13:36:26 +0900." <000f01bf2a6b$fc1eafc0$2801007e@cadzone.tpf.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 09 Nov 1999 13:15:34 +0200 From: Stoyan Genov Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by hub.org id GAA00825 > > > > > > > I knew the way to fix it but am not sure now. > > > > Do you really want to make it possible ? > > > > It isn't an appropriate way to get last rows because "move forward > > > > all" takes very long time. > > > > > > > > > > Of course it is not an appropriate way to get the last rows like this. > > > The "right" way IMHO is to reverse the order in the query and to get the > > > first > > > rows. > > > > > > It is just for the sake of truth... > > > > > > > OK Attached is a patch. > > Could you apply to 6.5.3 ? > > > > Sorry the patch is not right for 6.5.3 . > Please apply the following patch to 6.5.3 . > > Regards. > > Hiroshi Inoue > Inoue@tpf.co.jp > > *** access/heap/heapam.c.orig Mon Aug 2 14:56:36 1999 > --- access/heap/heapam.c Tue Nov 9 12:59:48 1999 > *************** > *** 775,782 **** > if (scan->rs_ptup.t_data == scan->rs_ctup.t_data && > BufferIsInvalid(scan->rs_pbuf)) > { > - if (BufferIsValid(scan->rs_nbuf)) > - ReleaseBuffer(scan->rs_nbuf); > return NULL; > } > > --- 775,780 ---- > *************** > *** 833,842 **** > ReleaseBuffer(scan->rs_pbuf); > scan->rs_ptup.t_data = NULL; > scan->rs_pbuf = InvalidBuffer; > - if (BufferIsValid(scan->rs_nbuf)) > - ReleaseBuffer(scan->rs_nbuf); > - scan->rs_ntup.t_data = NULL; > - scan->rs_nbuf = InvalidBuffer; > return NULL; > } > > --- 831,836 ---- > *************** > *** 855,862 **** > if (scan->rs_ctup.t_data == scan->rs_ntup.t_data && > BufferIsInvalid(scan->rs_nbuf)) > { > - if (BufferIsValid(scan->rs_pbuf)) > - ReleaseBuffer(scan->rs_pbuf); > HEAPDEBUG_3; /* heap_getnext returns NULL at end */ > return NULL; > } > --- 849,854 ---- > *************** > *** 915,924 **** > ReleaseBuffer(scan->rs_nbuf); > scan->rs_ntup.t_data = NULL; > scan->rs_nbuf = InvalidBuffer; > - if (BufferIsValid(scan->rs_pbuf)) > - ReleaseBuffer(scan->rs_pbuf); > - scan->rs_ptup.t_data = NULL; > - scan->rs_pbuf = InvalidBuffer; > HEAPDEBUG_6; /* heap_getnext returning EOS */ > return NULL; > } > --- 907,912 ---- > > > > ************ > I have applied the patch. Now postgres 6.5.3 works fine (FETCH BACKWARD fetches result after MOVE FORWARD ALL/FETCH FORWARD ALL). Thank you very much. Regards, Stoyan Genov