Received: from candle.pha.pa.us (pgman@s5-03.ppp.op.net [209.152.195.67]) by hub.org (8.9.3/8.9.3) with ESMTP id AAA52851; Fri, 28 Jan 2000 00:34:49 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id AAA11561; Fri, 28 Jan 2000 00:31:26 -0500 (EST) From: Bruce Momjian Message-Id: <200001280531.AAA11561@candle.pha.pa.us> Subject: Re: [SQL] RE: [GENERAL] Problem with SELECT on large negative INT4 In-Reply-To: <9485.949034954@sss.pgh.pa.us> from Tom Lane at "Jan 27, 2000 11:49:14 pm" To: Tom Lane Date: Fri, 28 Jan 2000 00:31:26 -0500 (EST) CC: John Brothers , pgsql-general@hub.org, pgsql-sql@hub.org X-Mailer: ELM [version 2.4ME+ PL66 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit > Actually, if Nicolas' table contains both very large positive and very > large negative integers, then his index could be messed up pretty badly. > What Hiroshi saw (and I missed :-() was that btint4cmp can fail and > return a result of the wrong sign if the difference between two integers > overflows. Since index sorting depends critically on the assumption > that the comparator always returns consistent results (a < b and b < c > must imply a < c, but this can fail if a - c overflows), you could have > an out-of-order index. And then probes into the index could fail to > find items they should find ... which is exactly the complained-of > symptom. > > Hiroshi neglected to mention that you'd probably need to drop and > recreate the index after applying the patch; if it's indeed out of > order, just patching the comparator bug isn't enough to fix it. > Does Hiroshi's patch get applied? -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026