Received: from candle.pha.pa.us (root@s5-03.ppp.op.net [209.152.195.67]) by hub.org (8.9.3/8.9.3) with ESMTP id MAA91028; Tue, 29 Feb 2000 12:56:15 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id MAA26276; Tue, 29 Feb 2000 12:21:26 -0500 (EST) From: Bruce Momjian Message-Id: <200002291721.MAA26276@candle.pha.pa.us> Subject: Re: [HACKERS] Re: [SQL] prob with aggregate and group by - returns multiplesh In-Reply-To: <29204.951840577@sss.pgh.pa.us> from Tom Lane at "Feb 29, 2000 11:09:37 am" To: Tom Lane Date: Tue, 29 Feb 2000 12:21:26 -0500 (EST) CC: Don Baccus , Thomas Lockhart , "'pgsql-sql@postgresql.org'" , PostgreSQL Development X-Mailer: ELM [version 2.4ME+ PL72 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Looks good to me. > Don Baccus writes: > > I vote for the SQL92 TEMPORARY. Let's not add a keyword that is non-standard > > just because one or another commercial database makes use of it, > > You're missing the point: we are not talking about *adding* a keyword, > we're talking about *removing* one that we've already supported for > a year or so. That changes matters considerably, IMHO. > > I have in fact been able to make a conflict-free grammar in which TEMP > is accepted but not reserved. It requires a certain amount of > redundancy in the productions (see below), but I think this is a > worthwhile tradeoff for not breaking existing user code. > > Shall I commit this? > > regards, tom lane > > > /* > * Redundancy here is needed to avoid shift/reduce conflicts, > * since TEMP is not a reserved word. See also OptTemp. > * > * The result is a cons cell (not a true list!) containing > * a boolean and a table name. > */ > OptTempTableName: TEMPORARY opt_table relation_name > { $$ = lcons(makeInteger(TRUE), (List *) $3); } > | TEMP opt_table relation_name > { $$ = lcons(makeInteger(TRUE), (List *) $3); } > | LOCAL TEMPORARY opt_table relation_name > { $$ = lcons(makeInteger(TRUE), (List *) $4); } > | LOCAL TEMP opt_table relation_name > { $$ = lcons(makeInteger(TRUE), (List *) $4); } > | GLOBAL TEMPORARY opt_table relation_name > { > elog(ERROR, "GLOBAL TEMPORARY TABLE is not currently supported"); > $$ = lcons(makeInteger(TRUE), (List *) $4); > } > | GLOBAL TEMP opt_table relation_name > { > elog(ERROR, "GLOBAL TEMPORARY TABLE is not currently supported"); > $$ = lcons(makeInteger(TRUE), (List *) $4); > } > | TABLE relation_name > { $$ = lcons(makeInteger(FALSE), (List *) $2); } > | relation_name > { $$ = lcons(makeInteger(FALSE), (List *) $1); } > ; > -- Bruce Momjian | http://www.op.net/~candle pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026