Received: from candle.pha.pa.us (candle.navpoint.com [162.33.245.46]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f310wZK05056 for ; Sat, 31 Mar 2001 19:58:35 -0500 (EST) (envelope-from pgman@candle.pha.pa.us) Received: (from pgman@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id TAA21172; Sat, 31 Mar 2001 19:58:17 -0500 (EST) From: Bruce Momjian Message-Id: <200104010058.TAA21172@candle.pha.pa.us> Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP In-Reply-To: <28177.986086419@sss.pgh.pa.us> "from Tom Lane at Mar 31, 2001 07:53:39 pm" To: Tom Lane Date: Sat, 31 Mar 2001 19:58:17 -0500 (EST) CC: Marcin Kowalski , PostgreSQL-development X-Mailer: ELM [version 2.4ME+ PL77 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Archive-Number: 200103/1579 X-Sequence-Number: 6951 > Bruce Momjian writes: > > First, here is a patch which will prevent this from happening in the > > future. Do people want this held for 7.2 or applied now? It disables > > the creation of user indexes on system tables. > > > + if (heapRelationName && !allow_system_table_mods && > > + IsSystemRelationName(heapRelationName) && IsNormalProcessingMode()) > > + { > > + elog(ERROR, "You can not create indexes on system tables: '%s'", > > + heapRelationName); > > + } > > + > > I think it would be a real good idea to put in this safeguard, but > I don't much like that error message. How about > > elog(ERROR, "User-defined indexes on system catalogs are not supported"); Change made to patch. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026