pg.ddx.io pgsql-sql@postgresql.org mailing list archive
help / color / mirror / Atom feedpltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
15+ messages / 6 participants
[nested] [flat]
* pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 09:11 Vsevolod Lobko <seva@sevasoft.kiev.ua>
0 siblings, 3 replies; 15+ messages in thread
From: Vsevolod Lobko @ 2002-01-23 09:11 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
On Sun, Jan 20, 2002 at 07:16:50PM -0500, Tom Lane wrote:
> Brent Verner <brent@rcfile.org> writes:
> > It seems that substvar operates on each " " separated token in the
> > string. The following works for me.
>
> > override TCL_SHLIB_LD := $(shell echo $(TCL_SHLIB_LD) | sed 's/-Wl,-soname.*//')
>
> I suspect that the above works only because -Wl,-soname is the last
> switch in TCL_SHLIB_LD; any following switches would be removed too.
> Perhaps better
>
> override TCL_SHLIB_LD := $(shell echo $(TCL_SHLIB_LD) | sed 's/-Wl,-soname[^ ]*//'
Sorry, but by this you broke freebsd build which has:
TCL_SHLIB_LD = ld -shared -x -soname $@
and $@ gets substituted too early
can you restrict this hack by putting something like
ifeq ($(PORTNAME), linux)
override TCL_SHLIB_LD := $(shell echo $(TCL_SHLIB_LD) | sed 's/-Wl,-soname[^ ]*//'
endif
instead?
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 14:56 Tom Lane <tgl@sss.pgh.pa.us>
parent: Vsevolod Lobko <seva@sevasoft.kiev.ua>
2 siblings, 0 replies; 15+ messages in thread
From: Tom Lane @ 2002-01-23 14:56 UTC (permalink / raw)
To: Murray Prior Hobbs <murray@efone.com>; +Cc: Vsevolod Lobko <seva@sevasoft.kiev.ua>; Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org; programmers@efone.com
Murray Prior Hobbs <murray@efone.com> writes:
> i made and installed
> and ran the check (make check) - 79 tests passed
> then i ran the make installcheck
> and get precisely the same failures as i got on my 686 over the last 3 days
PATH pointing at the wrong thing, or other conflicting environment
variables (eg PGPORT), I'd guess.
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 16:08 Tom Lane <tgl@sss.pgh.pa.us>
parent: Vsevolod Lobko <seva@sevasoft.kiev.ua>
2 siblings, 0 replies; 15+ messages in thread
From: Tom Lane @ 2002-01-23 16:08 UTC (permalink / raw)
To: Vsevolod Lobko <seva@sevasoft.kiev.ua>; +Cc: Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Vsevolod Lobko <seva@sevasoft.kiev.ua> writes:
>> Perhaps better
>>
>> override TCL_SHLIB_LD := $(shell echo $(TCL_SHLIB_LD) | sed 's/-Wl,-soname[^ ]*//'
> Sorry, but by this you broke freebsd build which has:
> TCL_SHLIB_LD = ld -shared -x -soname $@
> and $@ gets substituted too early
How annoying. I was debating whether to use single or double quotes
around the echo parameter --- looks like I made the wrong choice.
Will fix.
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and
@ 2002-01-23 16:48 Peter Eisentraut <peter_e@gmx.net>
parent: Vsevolod Lobko <seva@sevasoft.kiev.ua>
2 siblings, 1 reply; 15+ messages in thread
From: Peter Eisentraut @ 2002-01-23 16:48 UTC (permalink / raw)
To: Vsevolod Lobko <seva@sevasoft.kiev.ua>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Brent Verner <brent@rcfile.org>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Vsevolod Lobko writes:
> > override TCL_SHLIB_LD := $(shell echo $(TCL_SHLIB_LD) | sed 's/-Wl,-soname[^ ]*//'
>
> Sorry, but by this you broke freebsd build which has:
>
> TCL_SHLIB_LD = ld -shared -x -soname $@
>
> and $@ gets substituted too early
I've submitted a bug report to FreeBSD about this. Let's hope they fix it
soon.
--
Peter Eisentraut peter_e@gmx.net
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 16:54 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter_e@gmx.net>
0 siblings, 1 reply; 15+ messages in thread
From: Tom Lane @ 2002-01-23 16:54 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: Vsevolod Lobko <seva@sevasoft.kiev.ua>; Brent Verner <brent@rcfile.org>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Peter Eisentraut <peter_e@gmx.net> writes:
> I've submitted a bug report to FreeBSD about this. Let's hope they fix it
> soon.
Will it not work to do
$(shell echo '$(TCL_SHLIB_LD)' | sed ...
?
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 17:01 Brent Verner <brent@rcfile.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 15+ messages in thread
From: Brent Verner @ 2002-01-23 17:01 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
[2002-01-23 11:54] Tom Lane said:
| Peter Eisentraut <peter_e@gmx.net> writes:
| > I've submitted a bug report to FreeBSD about this. Let's hope they fix it
| > soon.
|
| Will it not work to do
|
| $(shell echo '$(TCL_SHLIB_LD)' | sed ...
No. I just tested this, and the $@ still got expanded too early.
We'll need to use the suggested ifeq($(PORTNAME),linux) test.
brent
--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 17:06 Tom Lane <tgl@sss.pgh.pa.us>
parent: Brent Verner <brent@rcfile.org>
0 siblings, 4 replies; 15+ messages in thread
From: Tom Lane @ 2002-01-23 17:06 UTC (permalink / raw)
To: Brent Verner <brent@rcfile.org>; +Cc: Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Brent Verner <brent@rcfile.org> writes:
> | Will it not work to do
> |
> | $(shell echo '$(TCL_SHLIB_LD)' | sed ...
> No. I just tested this, and the $@ still got expanded too early.
[ scratches head ... ] Where is the expansion happening, then? Seems
weird.
> We'll need to use the suggested ifeq($(PORTNAME),linux) test.
I don't much like that since it makes an inappropriate assumption,
viz that if you're on Linux you must have a TCL_SHLIB_LD value that
hasn't got any $variables in it. I'd prefer to figure out *why* we
are getting a premature evaluation.
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu
@ 2002-01-23 17:19 Bruce Momjian <pgman@candle.pha.pa.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
3 siblings, 0 replies; 15+ messages in thread
From: Bruce Momjian @ 2002-01-23 17:19 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Tom Lane wrote:
> Brent Verner <brent@rcfile.org> writes:
> > | Will it not work to do
> > |
> > | $(shell echo '$(TCL_SHLIB_LD)' | sed ...
>
> > No. I just tested this, and the $@ still got expanded too early.
>
> [ scratches head ... ] Where is the expansion happening, then? Seems
> weird.
>
> > We'll need to use the suggested ifeq($(PORTNAME),linux) test.
>
> I don't much like that since it makes an inappropriate assumption,
> viz that if you're on Linux you must have a TCL_SHLIB_LD value that
> hasn't got any $variables in it. I'd prefer to figure out *why* we
> are getting a premature evaluation.
As a data point, now that FreeBSD is showing problems too, I see this on
BSD/OS with TCL 8.3 in tclConfig.sh:
TCL_SHLIB_LD='cc -shared'
Does this mean I don't have the problem here?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 17:29 Brent Verner <brent@rcfile.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
3 siblings, 1 reply; 15+ messages in thread
From: Brent Verner @ 2002-01-23 17:29 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
[2002-01-23 12:06] Tom Lane said:
| Brent Verner <brent@rcfile.org> writes:
| > | Will it not work to do
| > |
| > | $(shell echo '$(TCL_SHLIB_LD)' | sed ...
|
| > No. I just tested this, and the $@ still got expanded too early.
|
| [ scratches head ... ] Where is the expansion happening, then? Seems
| weird.
apparently the $(shell ...) construct expands any shell-like
vars.
from make's info file:
The `shell' function performs the same function that backquotes
(``') perform in most shells: it does "command expansion".
| > We'll need to use the suggested ifeq($(PORTNAME),linux) test.
|
| I don't much like that since it makes an inappropriate assumption,
| viz that if you're on Linux you must have a TCL_SHLIB_LD value that
| hasn't got any $variables in it. I'd prefer to figure out *why* we
| are getting a premature evaluation.
maybe check for a '$' in the TCL_SHLIB_LD ? I've been trying
$(findstring ...) but have not gotten that to work right yet.
brent
--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and
@ 2002-01-23 17:59 Peter Eisentraut <peter_e@gmx.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
3 siblings, 2 replies; 15+ messages in thread
From: Peter Eisentraut @ 2002-01-23 17:59 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Brent Verner <brent@rcfile.org>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Tom Lane writes:
> [ scratches head ... ] Where is the expansion happening, then? Seems
> weird.
The $@ is expanded as a make variable. Make does care whether you're
executing a $(shell) thing around it. However, it seems that $@ should
expand to nothing in that assignment, so where's the problem?
--
Peter Eisentraut peter_e@gmx.net
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 17:59 Brent Verner <brent@rcfile.org>
parent: Brent Verner <brent@rcfile.org>
0 siblings, 0 replies; 15+ messages in thread
From: Brent Verner @ 2002-01-23 17:59 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
[2002-01-23 12:29] Brent Verner said:
| [2002-01-23 12:06] Tom Lane said:
| | Brent Verner <brent@rcfile.org> writes:
| | > | Will it not work to do
| | > |
| | > | $(shell echo '$(TCL_SHLIB_LD)' | sed ...
| |
| | > No. I just tested this, and the $@ still got expanded too early.
| |
| | [ scratches head ... ] Where is the expansion happening, then? Seems
| | weird.
|
| apparently the $(shell ...) construct expands any shell-like
| vars.
|
| from make's info file:
|
| The `shell' function performs the same function that backquotes
| (``') perform in most shells: it does "command expansion".
|
| | > We'll need to use the suggested ifeq($(PORTNAME),linux) test.
| |
| | I don't much like that since it makes an inappropriate assumption,
| | viz that if you're on Linux you must have a TCL_SHLIB_LD value that
| | hasn't got any $variables in it. I'd prefer to figure out *why* we
| | are getting a premature evaluation.
|
| maybe check for a '$' in the TCL_SHLIB_LD ? I've been trying
| $(findstring ...) but have not gotten that to work right yet.
The best I can come up with is checking for the offending string
'libtcl.so.0' in the TCL_SHLIB_LD.
ifneq (,$(findstring libtcl.so.0,$(TCL_SHLIB_LD)))
TCL_SHLIB_LD := $(shell echo '$(TCL_SHLIB_LD)' | sed 's/-Wl,-soname[^ ]*//')
endif
any better ideas out there? I've exhausted my PG time for today ;-)
brent
--
"Develop your talent, man, and leave the world something. Records are
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing." -- Duane Allman
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 18:02 Bernhard Herzog <bh@intevation.de>
parent: Tom Lane <tgl@sss.pgh.pa.us>
3 siblings, 1 reply; 15+ messages in thread
From: Bernhard Herzog @ 2002-01-23 18:02 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Tom Lane <tgl@sss.pgh.pa.us> writes:
> Brent Verner <brent@rcfile.org> writes:
> > | Will it not work to do
> > |
> > | $(shell echo '$(TCL_SHLIB_LD)' | sed ...
>
> > No. I just tested this, and the $@ still got expanded too early.
>
> [ scratches head ... ] Where is the expansion happening, then? Seems
> weird.
The expansion is done by make. It does expand variables recursively,
even for :=. Using $$@ instead of $@ should help in this particular
case, I think.
Bernhard
--
Intevation GmbH http://intevation.de/
Sketch http://sketch.sourceforge.net/
MapIt! http://mapit.de/
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 18:05 Tom Lane <tgl@sss.pgh.pa.us>
parent: Peter Eisentraut <peter_e@gmx.net>
1 sibling, 0 replies; 15+ messages in thread
From: Tom Lane @ 2002-01-23 18:05 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: Brent Verner <brent@rcfile.org>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Peter Eisentraut <peter_e@gmx.net> writes:
> Tom Lane writes:
>> [ scratches head ... ] Where is the expansion happening, then? Seems
>> weird.
> The $@ is expanded as a make variable. Make does care whether you're
> executing a $(shell) thing around it. However, it seems that $@ should
> expand to nothing in that assignment, so where's the problem?
I think the complaint is that we need it to still look like $@ when
TCL_SHLIB_LD is used in the shlib-building rule. If Make recursively
expands the variable before executing the $shell construct then we
got trouble.
Ugly as it is, the check on portname may be the best solution available.
I'm gonna think a little more, but I haven't got a better idea now.
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 18:07 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bernhard Herzog <bh@intevation.de>
0 siblings, 0 replies; 15+ messages in thread
From: Tom Lane @ 2002-01-23 18:07 UTC (permalink / raw)
To: Bernhard Herzog <bh@intevation.de>; +Cc: Brent Verner <brent@rcfile.org>; Peter Eisentraut <peter_e@gmx.net>; Vsevolod Lobko <seva@sevasoft.kiev.ua>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
Bernhard Herzog <bh@intevation.de> writes:
> Using $$@ instead of $@ should help in this particular
> case, I think.
But we haven't got control of what the initial value of TCL_SHLIB_LD is.
Hmm. Wait a minute; we're going about this all wrong. Instead of
hacking the Makefile, let's hack mkMakefile.tcldefs.sh. We can
definitely fix the TCL_SHLIB_LD value there, before Make sees it.
regards, tom lane
^ permalink raw reply [nested|flat] 15+ messages in thread
* Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems)
@ 2002-01-23 19:34 Vsevolod Lobko <seva@sevasoft.kiev.ua>
parent: Peter Eisentraut <peter_e@gmx.net>
1 sibling, 0 replies; 15+ messages in thread
From: Vsevolod Lobko @ 2002-01-23 19:34 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Brent Verner <brent@rcfile.org>; Murray Prior Hobbs <murray@efone.com>; Lamar Owen <lamar.owen@wgcr.org>; pgsql-hackers@postgresql.org
On Wed, Jan 23, 2002 at 12:59:00PM -0500, Peter Eisentraut wrote:
> Tom Lane writes:
>
> > [ scratches head ... ] Where is the expansion happening, then? Seems
> > weird.
>
> The $@ is expanded as a make variable. Make does care whether you're
> executing a $(shell) thing around it. However, it seems that $@ should
> expand to nothing in that assignment, so where's the problem?
exactly in that, so make triing to execute
ld -shared -x -soname -o pltcl.so pltcl.o
^ no arguments to -soname
^ permalink raw reply [nested|flat] 15+ messages in thread
end of thread, other threads:[~2002-01-23 19:34 UTC | newest]
Thread overview: 15+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2002-01-23 09:11 pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu problems) Vsevolod Lobko <seva@sevasoft.kiev.ua>
2002-01-23 14:56 ` Tom Lane <tgl@sss.pgh.pa.us>
2002-01-23 16:08 ` Tom Lane <tgl@sss.pgh.pa.us>
2002-01-23 16:48 ` Re: pltcl build problem on FreeBSD (was: Re: pltlc and Peter Eisentraut <peter_e@gmx.net>
2002-01-23 16:54 ` Tom Lane <tgl@sss.pgh.pa.us>
2002-01-23 17:01 ` Brent Verner <brent@rcfile.org>
2002-01-23 17:06 ` Tom Lane <tgl@sss.pgh.pa.us>
2002-01-23 17:19 ` Re: pltcl build problem on FreeBSD (was: Re: pltlc and pltlcu Bruce Momjian <pgman@candle.pha.pa.us>
2002-01-23 17:29 ` Brent Verner <brent@rcfile.org>
2002-01-23 17:59 ` Brent Verner <brent@rcfile.org>
2002-01-23 17:59 ` Re: pltcl build problem on FreeBSD (was: Re: pltlc and Peter Eisentraut <peter_e@gmx.net>
2002-01-23 18:05 ` Tom Lane <tgl@sss.pgh.pa.us>
2002-01-23 19:34 ` Vsevolod Lobko <seva@sevasoft.kiev.ua>
2002-01-23 18:02 ` Bernhard Herzog <bh@intevation.de>
2002-01-23 18:07 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox