Content-Type: text/plain;
  charset="iso-8859-1"
From: Richard Huxton <dev@archonet.com>
Organization: Archonet Ltd
To: monroy@mindspring.com (javaholic), pgsql-sql@postgresql.org
Subject: Re: How does postgres handle non literal string values
Date: Tue, 26 Nov 2002 15:35:02 +0000
User-Agent: KMail/1.4.3
References: <8adde2e2.0211250457.3f0d1c7c@posting.google.com>
In-Reply-To: <8adde2e2.0211250457.3f0d1c7c@posting.google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Message-Id: <200211261535.02419.dev@archonet.com>

On Monday 25 Nov 2002 12:57 pm, javaholic wrote:
> Hi All,
>
> I have some jsp code that should insert a user name and password into
> a table called login.
>
> Instead of inserting the values given by the client, it insert the
> literal string 'username' and 'password. The problem is somewhere in
> the INSERT statement.

>                         String insertString =3D
>                         "INSERT INTO  \"login\" (\'user\', \'password\')
> VALUES ('username', 'password')";

You're creating an insertString with the literal words "username" and=20
"password" in them. This is a java issue, not a PG issue. You'll want=20
something like (sorry if syntax is wrong, but I don't do Java):

String insertString =3D "Insert INTO ... VALUES ('" + sql_escaped(username)=
 +=20
"')..."

You *will* want to escape the username and password otherwise I'll be able =
to=20
come along and insert any values I like into your database. I can't believe=
=20
the JDBC classes don't provide=20

1. Some way to escape value strings
2. Some form of placeholders to deal with this

--=20
  Richard Huxton