X-Original-To: pgsql-sql@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id A0F9447580B for ; Sat, 26 Apr 2003 00:48:51 -0400 (EDT) Received: from rtlocal.trade-india.com (unknown [203.196.129.235]) by postgresql.org (Postfix) with SMTP id 89607474E42 for ; Sat, 26 Apr 2003 00:48:45 -0400 (EDT) Received: (qmail 1595 invoked from network); 26 Apr 2003 04:48:48 -0000 Received: from unknown (HELO system67.trade-india-local.com) (unknown) by unknown with SMTP; 26 Apr 2003 04:48:48 -0000 From: Rajesh Kumar Mallah Organization: Infocom Network Limited To: Tom Lane Subject: Re: /* */ comments showing up in pg_stat_activity Date: Sat, 26 Apr 2003 10:18:43 +0530 User-Agent: KMail/1.5 Cc: pgsql-sql@postgresql.org References: <200304251617.h3PGHWZ24565@candle.pha.pa.us> <3EA9F35A.848AB5D1@Yahoo.com> <11772.1051326326@sss.pgh.pa.us> In-Reply-To: <11772.1051326326@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200304261018.43661.mallah@trade-india.com> X-Spam-Status: No, hits=-33.7 required=5.0 tests=BAYES_01,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT, QUOTE_TWICE_1,REFERENCES,REPLY_WITH_QUOTES, SIGNATURE_SHORT_SPARSE,USER_AGENT autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/391 X-Sequence-Number: 13092 On Saturday 26 Apr 2003 8:35 am, Tom Lane wrote: > Jan Wieck writes: > > The question back is from where does such a query with a comment come? > > If it is a standard client like psql, it could happen someday that this > > client does some filtering. Yes its thru psql only , i run a SQL batch using psql -e -h db -f batch.sql In case future version of psql strips them it would still be nice if libpq continue supporting it i feel it would be a nice feature for keeping track of queries. Regds Mallah. > > psql already does strip comments (and always has, AFAIK). > > > If you're using libpq or another API that is > > basically a libpq wrapper, you're pretty safe. > > Agreed, I doubt we'd ever bother to put comment-stripping logic in libpq. > > regards, tom lane -- Rajesh Kumar Mallah, Project Manager (Development) Infocom Network Limited, New Delhi phone: +91(11)6152172 (221) (L) ,9811255597 (M) Visit http://www.trade-india.com , India's Leading B2B eMarketplace.