To: Gregory Stark <stark@enterprisedb.com>
cc: "Michele Petrazzo - Unipex srl" <michele.petrazzo@unipex.it>,
	"Pgsql-Sql" <pgsql-sql@postgresql.org>, pgsql-hackers@postgresql.org
Subject: Re: functions are returns columns 
In-reply-to: <874pftdd89.fsf@oxford.xeocode.com> 
References: <4734B921.5050704@unipex.it>
	<162867790711091235i7e77abcch27731d91285949b6@mail.gmail.com>
	<4735EC6F.5050908@unipex.it> <878x55dhau.fsf@oxford.xeocode.com>
	<19335.1194723995@sss.pgh.pa.us>
	<874pftdd89.fsf@oxford.xeocode.com>
Comments: In-reply-to Gregory Stark <stark@enterprisedb.com>
	message dated "Sat, 10 Nov 2007 21:04:06 +0000"
Date: Sat, 10 Nov 2007 18:14:50 -0500
Message-ID: <21435.1194736490@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>> Not quite --- it's just "returns setof record".

> I did test my example before posting it:

> postgres=# postgres=# CREATE or replace FUNCTION getfoo (IN int, OUT int, OUT int) returns setof record(int,int)AS $$
>    SELECT 1,2 union all select 2,3;
> $$ LANGUAGE SQL;

Interesting --- if you try it in anything older than 8.3, it will fail.

What is happening here is that the "(int,int)" is being taken as a
typmod (per Teodor's work to allow typmods for all data types), and
apparently in this path we never check to see if it's a *valid* typmod.

Now typmods are always discarded from function argument and result
types, but it seems like we'd better validate that they're legal for the
datatype anyway.  Otherwise there will be confusion of just this sort.

Comments, objections?

			regards, tom lane