Received: from sss.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by hub.org (8.9.3/8.9.3) with ESMTP id KAA45756 for ; Fri, 9 Jul 1999 10:26:00 -0400 (EDT) (envelope-from tgl@sss.pgh.pa.us) Received: from sss.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.sss.pgh.pa.us (8.9.1/8.9.1) with ESMTP id KAA02316; Fri, 9 Jul 1999 10:24:05 -0400 (EDT) To: Jim Rowan cc: jwieck@debis.com (Jan Wieck), ertz@illite.u-strasbg.fr (Olivier Ertz), pgsql-sql@postgreSQL.org Subject: Re: [SQL] RewriteDefine.c : Rule size In-reply-to: Your message of Thu, 08 Jul 1999 23:25:04 -0500 <199907090425.XAA12140@zee.computing.com> Date: Fri, 09 Jul 1999 10:24:05 -0400 Message-ID: <2314.931530245@sss.pgh.pa.us> From: Tom Lane Jim Rowan writes: > First we multiplied it * 4. This improved the ability to handle complex > rules, but didn't go far enough... (it still wouldn't handle all of what we > wanted it to). > So we multiplied it * 8. Initdb complained about "float4 not > defined". There is a poorly-documented restriction that BLCKSZ can't exceed 32K (IIRC, this is because block offsets are stored in signed shorts somewhere). Probably would be a good idea to mention this in the comments in config.h.in. For the long run it would be nice to remove the restriction. I have no idea whether that would be easy or hard. Ideally we could do something like #if BLCKSZ > 32767 typedef int BlockOffset; #else typedef short BlockOffset; #endif but finding all the places that need to use the typedef might be a pain. regards, tom lane