Received: from sss.pgh.pa.us ([216.151.103.158]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f3HI1Ru95913 for ; Tue, 17 Apr 2001 14:01:27 -0400 (EDT) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.3/8.11.3) with ESMTP id f3HI1MR24855; Tue, 17 Apr 2001 14:01:22 -0400 (EDT) To: Jeff Hoffmann cc: pgsql-sql@postgresql.org Subject: Re: RTREE on points In-reply-to: <3ADC7E8F.7569BABD@propertykey.com> References: <9bbtqv$688$1@news.tht.net> <3ADAFF38.E7147C8D@propertykey.com> <008f01c0c68a$b6651c00$2285fd3e@julian> <3ADB65F4.6F83A1E7@propertykey.com> <19849.987464946@sss.pgh.pa.us> <3ADC6B1D.5C4C2D71@propertykey.com> <24276.987525349@sss.pgh.pa.us> <3ADC7E8F.7569BABD@propertykey.com> Comments: In-reply-to Jeff Hoffmann message dated "Tue, 17 Apr 2001 12:34:07 -0500" Date: Tue, 17 Apr 2001 14:01:22 -0400 Message-ID: <24852.987530482@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200104/273 X-Sequence-Number: 2628 Jeff Hoffmann writes: > Tom Lane wrote: >> How the heck did the GIST index code get developed/tested without some >> opclasses? > doing some digging at berkeley, i found the original pggist patch file > that created the gist access method & gist_box_ops opclass (among > others). i'm assuming that patch was the basis for what was originally > introduced, so i don't know why it didn't get included with everything > else. The CVS logs show there was some confusion about applying the whole of the pggist patch, so it's possible that this was an unintentional omission. > it looks like there are a lot of calls to internal postgresql box > comparison functions that would need to get converted to the new calling > convention, but it should be pretty straightforward to get it to work > with a recent version of postgresql. it does seem pretty silly to have > it in there if you don't have any built-in way of using it, if for no > other reason than to be able to test if the feature even works. Yes. I had been thinking of migrating one or more of the new contrib GIST opclasses into the main distribution for 7.2, if only to be able to create a regress test for GIST. Updating this old Berkeley code would be another path to create/extend a GIST regress test. If you (or someone else) have time to do that, it'd be great. regards, tom lane