Received: from sss2.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by hub.org (8.9.3/8.9.3) with ESMTP id LAA34934 for ; Mon, 28 Feb 2000 11:26:56 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss2.sss.pgh.pa.us (8.9.3/8.9.3) with ESMTP id LAA25676; Mon, 28 Feb 2000 11:26:35 -0500 (EST) To: Thomas Lockhart cc: pgsql-hackers@postgreSQL.org Subject: Re: [HACKERS] Re: missing function datetime() In-reply-to: <38BAA1C2.65971352@alumni.caltech.edu> References: <23337.951436670@sss.pgh.pa.us> <006e01bf7f81$b9a91d40$760e01a3@oucs.ox.ac.uk> <7619.951496583@sss.pgh.pa.us> <38BAA1C2.65971352@alumni.caltech.edu> Comments: In-reply-to Thomas Lockhart message dated "Mon, 28 Feb 2000 16:26:42 +0000" Date: Mon, 28 Feb 2000 11:26:35 -0500 Message-ID: <25673.951755195@sss.pgh.pa.us> From: Tom Lane Thomas Lockhart writes: >> I can see two ways to do that: either add another function to pg_proc >> (five of them actually :-(), or hack the parser to translate a function >> name 'datetime' to 'timestamp'. Ugly as the second one sounds, it has >> a couple of advantages. > xlateSqlFunc() is already in gram.y; enjoy... Will do, just wanted to see if you approved or not. When you finish catching up on the back email, I'd like to know what you think about the question of comment lexing. Should we change scan.l so that it will recognize /* or -- as comment starters even if they are embedded in what would currently be considered a long operator token? If so, is it OK to depend on yyless() to do it, or is that a flex-ism? I'd also kind of like to put in a test to detect unterminated comments and literals. The flex manual recommends <> but that only works in flex. I was speculating that a rule for followed by nothing might work, if all the other rules match at least one character. Thoughts? regards, tom lane