Received: from sss.pgh.pa.us ([216.151.103.158]) by postgresql.org (8.11.3/8.11.1) with ESMTP id f310rrK04235 for ; Sat, 31 Mar 2001 19:53:53 -0500 (EST) (envelope-from tgl@sss.pgh.pa.us) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.11.3/8.11.3) with ESMTP id f310rdw28180; Sat, 31 Mar 2001 19:53:39 -0500 (EST) To: Bruce Momjian cc: Marcin Kowalski , PostgreSQL-development Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP In-reply-to: <200103310114.UAA13928@candle.pha.pa.us> References: <200103310114.UAA13928@candle.pha.pa.us> Comments: In-reply-to Bruce Momjian message dated "Fri, 30 Mar 2001 20:14:50 -0500" Date: Sat, 31 Mar 2001 19:53:39 -0500 Message-ID: <28177.986086419@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200103/1578 X-Sequence-Number: 6950 Bruce Momjian writes: > First, here is a patch which will prevent this from happening in the > future. Do people want this held for 7.2 or applied now? It disables > the creation of user indexes on system tables. > + if (heapRelationName && !allow_system_table_mods && > + IsSystemRelationName(heapRelationName) && IsNormalProcessingMode()) > + { > + elog(ERROR, "You can not create indexes on system tables: '%s'", > + heapRelationName); > + } > + I think it would be a real good idea to put in this safeguard, but I don't much like that error message. How about elog(ERROR, "User-defined indexes on system catalogs are not supported"); regards, tom lane