Received: from golem.jpl.nasa.gov (IDENT:root@hectic-2.jpl.nasa.gov [128.149.68.204]) by hub.org (8.9.1/8.9.1) with ESMTP id TAA16447 for ; Sun, 13 Dec 1998 19:28:17 -0500 (EST) (envelope-from lockhart@alumni.caltech.edu) Received: from alumni.caltech.edu (localhost [127.0.0.1]) by golem.jpl.nasa.gov (8.8.5/8.8.5) with ESMTP id AAA26622; Mon, 14 Dec 1998 00:24:41 GMT Sender: tgl@mythos.jpl.nasa.gov Message-ID: <36745AC9.3EF6DB74@alumni.caltech.edu> Date: Mon, 14 Dec 1998 00:24:41 +0000 From: "Thomas G. Lockhart" Organization: Caltech/JPL X-Mailer: Mozilla 4.07 [en] (X11; I; Linux 2.0.30 i686) MIME-Version: 1.0 To: Bruce Momjian CC: Tom Lane , pgsql-sql@hub.org Subject: Re: [SQL] char type seems the same as char(1) References: <199812131931.OAA01559@candle.pha.pa.us> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit > > Well, Tom Lockhart responded that "it's not a bug, it's a feature". > > I still think it's broken --- and certainly the fact that quoting > > affects the result (char and "char" act differently) is not good. OK, I've committed changes to *both* trees prompted by the problems with handling the single-byte character type. One set of changes removes the double quotes from most data type fields in pg_dump (they aren't really legal there in the SQL92 sense anyway). pg_dump now writes "character" and "character varying" for the Postgres internal types "bpchar" and "varchar" to be more compatible with standard usage. Another set of changes modifies the type matching for DEFAULT statements to use the recently implemented implicit type coersion techniques. More permutations of DEFAULT clauses should now be legal and handled. Please test this stuff! Especially if you are set up to test the REL6_4 tree since I've done all testing on the main development tree. btw, all regression tests pass on my machine. > If we use char1 for internal tables, we should allow it externally, if > only as char1. I will add it to the TODO list. As what? - Tom