Received: from davinci.ethosmedia.com (davinci.ethosmedia.com [209.10.40.250]) by mail.postgresql.org (8.11.1/8.11.1) with ESMTP id f1KHwEx38369 for ; Tue, 20 Feb 2001 12:58:14 -0500 (EST) (envelope-from josh@agliodbs.com) Received: from [207.172.28.154] (HELO agliodbs.com) by davinci.ethosmedia.com (CommuniGate Pro SMTP 3.3) with ESMTP id 1192809; Tue, 20 Feb 2001 09:58:13 -0800 Message-ID: <3A92B031.B2B6119B@agliodbs.com> Date: Tue, 20 Feb 2001 09:58:09 -0800 From: Josh Berkus Reply-To: josh@agliodbs.com Organization: Aglio Database Solutions X-Mailer: Mozilla 4.73 [en] (Win98; I) X-Accept-Language: en MIME-Version: 1.0 To: Tom Lane CC: sqllist , Jan Wieck Subject: Re: Huh? Mysterious Function Error References: <3A92A15E.1E7DF00D@agliodbs.com> <15771.982690612@sss.pgh.pa.us> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Archive-Number: 200102/315 X-Sequence-Number: 1511 Tom, Stephan, > Josh Berkus writes: > > ERROR: unexpected SELECT query in exec_stmt_execsql() > > plpgsql doesn't think you should execute bare SELECTs, only SELECT INTO. That would explain it. I have a nested function call in the form: SELECT fn_remove_lock(record_id, user_id); Because I didn't care what the function returned and SELECT is the simplest form. Easily fixed. > > On reflection this seems an overly anal-retentive restriction, since > there are cases where one might execute a SELECT for its side effects > alone ("SELECT setval()" comes to mind). > Jan, do you think there's a good case for refusing plain SELECTs? I can think of one, myself. In some systems (MS SQL Server), all plain selects are returned by stored procedures as query results; thus a stored procedure is able to return multiple rowsets. In other systems, the single returned rowset is given by the last palin SELECT in the procedure. Thus, until PGSQL *does* support stored procedures, refusing plain SELECTs may be a good way to remind procedure-writers that we do not have the ability to return rowsets. For stuff like my procedure, or Tom's example, one can always designate a dummy variable with: dummy_variable := setval('some_sq',321); Which should have the same effect. -Josh Berkus -- ______AGLIO DATABASE SOLUTIONS___________________________ Josh Berkus Complete information technology josh@agliodbs.com and data management solutions (415) 565-7293 for law firms, small businesses fax 621-2533 and non-profit organizations. San Francisco