Received: from sd.tpf.co.jp (sd.tpf.co.jp [210.161.239.34]) by postgresql.org (8.11.3/8.11.1) with SMTP id f2UAE8K11182 for ; Fri, 30 Mar 2001 05:14:19 -0500 (EST) (envelope-from Inoue@tpf.co.jp) Received: (qmail 27372 invoked from network); 30 Mar 2001 10:13:31 -0000 Received: from unknown (HELO tpf.co.jp) (126.0.1.61) by sd2.10.0.100.in-addr.arpa with SMTP; 30 Mar 2001 10:13:31 -0000 Message-ID: <3AC45CBA.8CDC3213@tpf.co.jp> Date: Fri, 30 Mar 2001 19:15:22 +0900 From: Hiroshi Inoue X-Mailer: Mozilla 4.73 [ja] (Windows NT 5.0; U) X-Accept-Language: ja MIME-Version: 1.0 To: "Mikheev, Vadim" CC: Philip Warner , Tom Lane , pgsql-sql@postgresql.org, pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Re: possible row locking bug in 7.0.3 & 7.1 References: <8F4C99C66D04D4118F580090272A7A234D335E@sectorbase1.sectorbase.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Archive-Number: 200103/629 X-Sequence-Number: 2300 "Mikheev, Vadim" wrote: > > > > >> I assume this is not possible in 7.1? > > > > > > > >Just looked in heapam.c - I can fix it in two hours. > > > >The question is - should we do this now? > > > >Comments? > > > > > > It's a bug; how confident are you of the fix? > > 95% -:) > > > I doubt if it's a bug of SELECT. Well what > > 'concurrent UPDATE then SELECT FOR UPDATE + > > SELECT' return ? > > I'm going to add additional check to heapgettup and > heap_fetch: > SELECT seems to be able to return a different result from that of preceding SELECT FOR UPDATE even after applying your change. SELECT doesn't seem guilty but the result is far from intuitive. It seems impossoble for all queires inside such a function to use a common snapshot. regards, Hiroshi Inoue