X-Original-To: pgsql-sql@postgresql.org Received: from spampd.localdomain (postgresql.org [64.49.215.8]) by postgresql.org (Postfix) with ESMTP id 8D29F476227 for ; Fri, 25 Apr 2003 22:49:08 -0400 (EDT) Received: from europa.janwieck.net (h00045a2e4e7c.ne.client2.attbi.com [24.131.181.55]) by postgresql.org (Postfix) with ESMTP id B296E4760CC for ; Fri, 25 Apr 2003 22:49:07 -0400 (EDT) Received: from Yahoo.com (dhcpclnt00.janwieck.net [192.168.192.100]) (authenticated) by europa.janwieck.net (8.11.6/8.11.6) with ESMTP id h3Q2mKa25208; Fri, 25 Apr 2003 22:48:20 -0400 Message-ID: <3EA9F35A.848AB5D1@Yahoo.com> Date: Fri, 25 Apr 2003 22:47:54 -0400 From: Jan Wieck Organization: Home X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en,ru MIME-Version: 1.0 To: Bruce Momjian Cc: Rajesh Kumar Mallah , pgsql-sql@postgresql.org Subject: Re: /* */ comments showing up in pg_stat_activity References: <200304251617.h3PGHWZ24565@candle.pha.pa.us> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-29.3 required=5.0 tests=BAYES_01,EMAIL_ATTRIBUTION,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) X-Archive-Number: 200304/388 X-Sequence-Number: 13089 We do, but that wasn't the question. I think you can asume that it'll stay that way because it is part of the query string the backend is currently chewing on. What shows up in pg_stat_activity is whatever was in the received query buffer before starting to parse it. So we would have a hard time at that point to filter out the comments. The question back is from where does such a query with a comment come? If it is a standard client like psql, it could happen someday that this client does some filtering. If you're using libpq or another API that is basically a libpq wrapper, you're pretty safe. Jan Bruce Momjian wrote: > > Yes, we support /* */ comments. > > --------------------------------------------------------------------------- > > Rajesh Kumar Mallah wrote: > > > > > > > > Hmm .. > > i just saw /* */ comments are being shown in current_query > > is it ok ? > > > > More importantly is it supposed to remain like that ? > > In that case i can tag every query with some identifier > > to know from which application it originated when i check > > em in pg_stat_activity ! > > > > > > regds > > mallah. > -- #======================================================================# # It's easier to get forgiveness for being wrong than for being right. # # Let's break this rule - forgive me. # #================================================== JanWieck@Yahoo.com #