Message-ID: <41222A26.1080204@sympatico.ca>
Date: Tue, 17 Aug 2004 11:54:14 -0400
From: Jean-Luc Lachance <jllachan@sympatico.ca>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.4) Gecko/20030624 Netscape/7.1 (ax)
MIME-Version: 1.0
To: pgsql-sql@postgresql.org
Cc: Markus Bertheau <twanger@bluetwanger.de>
Subject: Re: SELECT MAX(c) FROM (SELECT ... FOR UPDATE) AS foo
References: <1092740863.2627.17.camel@dicaprio.akademie1.de>	
	<20040817141229.GA15770@wolff.to>
	<1092752492.2627.23.camel@dicaprio.akademie1.de>
In-Reply-To: <1092752492.2627.23.camel@dicaprio.akademie1.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

If your intent is to insert a new record with position incremented by 1, 
you should use a trigger. Look at the autoincrement thread from few days 
ago.


Markus Bertheau wrote:

> В Втр, 17.08.2004, в 16:12, Bruno Wolff III пишет:
> 
>>>SELECT MAX(position) FROM (SELECT position FROM classes WHERE name =
>>>'foo' FOR UPDATE OF classes) AS foo
>>>
>>>It's clear which rows should be locked here, I think.
>>
>>Even if it was allowed, it probably wouldn't be good enough because it won't
>>protect against newly inserted records.
> 
> 
> Can you detail an example where this wouldn't be good enough?
> 
> In a PL/pgSQL function I'm doing
> 
> PERFORM position FROM class_fields WHERE class = arg_class_name;
> INSERT INTO class_fields (class, field, position) VALUES
> (arg_class_name, arg_field_name, (SELECT MAX(position) FROM class_fields
> WHERE class = arg_class_name));
> 
> Is this unsafe?
> 
> The question initially arose because I wanted to do something similar to
> 
> SELECT INTO var_new_position MAX(position) FROM class_fields WHERE class
> = arg_class_name FOR UPDATE OF class_fields;
> 
> which didn't work.
> 
> Thanks
>