To: Rob Sargent <robjsargent@gmail.com>
cc: pgsql-sql@postgresql.org
Subject: Re: pass in array to function for use by where clause? how optimize? 
In-reply-to: <4DA5C5CB.3030907@gmail.com> 
References: <BANLkTinHyTWh-HZPm0XoTqYEtEqJ8T-iRw@mail.gmail.com>
	<5079.1302707363@sss.pgh.pa.us> <4DA5C5CB.3030907@gmail.com>
Comments: In-reply-to Rob Sargent <robjsargent@gmail.com>
	message dated "Wed, 13 Apr 2011 09:48:27 -0600"
Date: Wed, 13 Apr 2011 12:15:33 -0400
Message-ID: <6181.1302711333@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Rob Sargent <robjsargent@gmail.com> writes:
> On 04/13/2011 09:09 AM, Tom Lane wrote:
>> Anish Kejariwal<anishkej@gmail.com>  writes:
>>> (select store_id, avg(sales) sales
>>> from store
>>> where group_id in(select $1[i] from generate_subscripts($1, 1) g(i))

>> Seems like a pretty brute-force way to deal with the array.  Try
>> where group_id = any($1)
>> Not sure if it'll be a great deal faster, but it's at least easier to
>> write.

> Would adding a subservient function which actually uses the value of the 
> iteration (group_id) as a single parameter be of any use?

Well, it'd be unlikely to solve the OP's actual complaint, which was
performance.  Hiding the semantics from the planner via a function
(which generally looks like a black box to the planner) is even worse
than hiding the semantics in a sub-SELECT, which I think is probably
the root cause of the performance issue here.

			regards, tom lane